Created attachment 210738 [details] victor-mono-ttf-1.3.1.diff Changes: * Bump DISTVERSION to 1.3.1 and regenerate distinfo. QA: * Portlint: Looks fine; * Poudriere: Package built (logs included).
Created attachment 210739 [details] victor-mono-ttf-1.3.1.log * Attached Poudriere build log.
I cannot retrieve the new zipball in attachment 210738 [details]. I tried the following URLs: - https://rubjo.github.io/victor-mono/VictorMonoAll.zip - https://github.com/rubjo/victor-mono/raw/v1.3.1/public/VictorMonoAll.zip But all of them are SHA256 (VictorMonoAll.zip) = 2fb18068fb921e4580e96540f2626c0c4b033eae8da35dd892e5a9ce52cd0ed9 SIZE (VictorMonoAll.zip) = 6474704
(In reply to Sunpoet Po-Chuan Hsieh from comment #2) Thanks for catching this. I'm not quite sure where I got that sha256 sum from; although I ran `make distclean` and `make makesum` again now I get the same results as you. I've taken a further look into the latest tag release which includes the source and found: public ζ sha256 VictorMonoAll.zip SHA256 (VictorMonoAll.zip) = 2fb18068fb921e4580e96540f2626c0c4b033eae8da35dd892e5a9ce52cd0ed9 public ζ Which matches the exact same sha256 sum of 1.3.0 - so either the author forgot to rebuild the font /or/ there's a reason behind it. In the latest tag release the only difference is (https://github.com/rubjo/victor-mono/commit/fa006fd5a9775e63536d03d24934d95223c4409f) - nothing that effects the archive itself. In any case, I created an issue on Github: https://github.com/rubjo/victor-mono/issues/66.
(In reply to Sunpoet Po-Chuan Hsieh from comment #2) Found the issue. During the initial submission (refer to the patch here https://bz-attachments.freebsd.org/attachment.cgi?id=210619) the sha256 hash was '13a0b209eaafc4a935404bae51aba7aaa9c73a2bbefc1c70195a585723b48ce0' - at the time was the latest release 0.3.0. However, when merged into the ports tree the 'distinfo' was regenerated and subsequently the hash was updated too (https://svnweb.freebsd.org/ports/head/x11-fonts/victor-mono-ttf/distinfo?view=co). There's a discrepancy to what was submitted and what was merged. This is where the confusion arose from. Anywho, should I drop the patch for `distinfo` and simply keep the bump in DISTVERSION?
Optionally, I believe it would be a good idea to set MASTER_SITES to 'https://github.com/rubjo/${PORTNAME}/raw/v${DISTVERSION}/public/' - this then avoids the issue as aforementioned.
Created attachment 210762 [details] victor-mono-ttf-1.3.1.diff * Address comment #5.
Created attachment 210765 [details] victor-mono-ttf-1.3.1.diff * Minor refactor, use '${DISTVERSIONFULL}' in-place of 'v${DISTVERSION}'.
A commit references this bug: Author: sunpoet Date: Fri Jan 17 15:03:28 UTC 2020 New revision: 523301 URL: https://svnweb.freebsd.org/changeset/ports/523301 Log: Fix DISTVERSION - Update MASTER_SITES PR: 243353 Submitted by: Lewis Cook <vulcan@wired.sh> (maintainer) Changes: head/x11-fonts/victor-mono-ttf/Makefile
Committed. Thanks!