Created attachment 211067 [details] upnp - 1.12.0 Update to 1.12.0. Changelog: https://github.com/pupnp/pupnp/blob/master/ChangeLog Tested successfully with poudriere on {11.3,12.1}-RELEASE {i386,amd64}. ---------- The following ports optionally depends on devel/upnp and should probably have a PORTREVISION bump: - net-p2p/amule; - net-p2p/amule-devel; - multimedia/vlc. I have tested successfully all of them with poudriere on {11.3,12.1}-RELEASE {i386,amd64}.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/112404820
I'll take this.
I propose the following commit log: Update to 1.12.0. * Reduce spurious HTTP 416 errors due to ill-defined bytes header * Remove unused files * UpnpEnableWebserver: Error correctly when web server compiled-out * Remove TRUE/FALSE defines and BOOL typedef * Add list test * Doxygen changes * Remove unused headers * Remove IN, OUT and INOUT defines * Remove unused defines in uri.h * Use stdbool.h instead of BOOL typedef and defines * Various compiler warning fixes * configure.ac: Enable silent rules * Remove and replace the list.h file * config.h: Remove DEBUG_TARGET * Check for -lpthread too (updates pthread m4 check from upstream)
(In reply to Lorenzo Salvadore from comment #3) > I propose the following commit log: Thank you, Lorenzo! When it comes to describing what a new version brings, my recommendation is to focus on changes (potentially) relevant or even visible to consumers. So "* Remove unused files" and "* Remove unused headers" are two entries I might omit (apart from the latter being a subset of the former) for example, similar to how I omit Arm-related or Cygwin-related changes when it comes to update of the emulators/wine* ports. In this specific case maybe something like * Streamline codebase by trimming unnecessary files, defines,... to cover a number of the proposed entries? Does "* Doxygen changes" mean "documentation improvements"?
(In reply to Gerald Pfeifer from comment #4) Thanks for your suggestions. I was already trying to do such kind of things, but I guess I need some practice, so your suggestions are indeed very useful. The doxygen changes refer to the following pull request: https://github.com/pupnp/pupnp/pull/142 As you can see from the files changed, there is a very small amount of new documentation added in it and they all refer to other things that are in the list. So I think we can drop this element from the list. I try to propose a new commit log version: Update to 1.12.0. * Reduce spurious HTTP 416 errors due to ill-defined bytes header * UpnpEnableWebserver: Error correctly when web server compiled-out * Remove TRUE/FALSE defines and BOOL typedef * Add list test * Remove IN, OUT and INOUT defines * Replace the list.h file * Check for -lpthread too (updates pthread m4 check from upstream)
(In reply to Lorenzo Salvadore from comment #5) > I try to propose a new commit log version: Thank you! I'm making a small number of tweaks on plan to commit this tomorrow. (Somehow in FreeBSD '-' seems more common than '*' when it comes to lists in commit messages, so this is one of the minor tweaks I'm making; not a rule I am aware of, more like a silent practice. Just in case you wonder.)
A commit references this bug: Author: gerald Date: Wed Feb 19 11:52:30 UTC 2020 New revision: 526508 URL: https://svnweb.freebsd.org/changeset/ports/526508 Log: devel/upnp: Update to version 1.12.0 which includes the following changes: - Reduce spurious HTTP 416 errors due to ill-defined bytes header. - UpnpEnableWebserver: Error correctly when web server compiled-out. - Remove TRUE/FALSE, IN/OUT/INOUT defines and BOOL typedef. - Add list test and replace the list.h file. - Check for -lpthread too (updates pthread m4 check from upstream). Bump PORTREVISION of dependent ports. PR: 243619 Submitted by: salvadore (maintainer) Changes: head/devel/upnp/Makefile head/devel/upnp/distinfo head/devel/upnp/pkg-plist head/multimedia/vlc/Makefile head/net-p2p/amule/Makefile head/net-p2p/amule-devel/Makefile
Thank you for the update, Lorenzo! I made some final adjustments to the commit message following your proposal. Hope that's fine, and let me know if you have any questions!