Bug 243917 - security/munge: rc script sends unnecessary SIGKILL to stop munged daemon
Summary: security/munge: rc script sends unnecessary SIGKILL to stop munged daemon
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-06 02:07 UTC by Chris Dunlap
Modified: 2020-02-12 22:01 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)

Attachments
send sigterm in munged_stop() to stop munged daemon (396 bytes, patch)
2020-02-06 02:07 UTC, Chris Dunlap 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dunlap 2020-02-06 02:07:24 UTC 
Created attachment 211400 [details]
send sigterm in munged_stop() to stop munged daemon

The rc script stops the munged daemon via kill -9.  This prevents munged from cleaning up, writing its prng seedfile, and removing its socket/lockfile/pidfile.

Update munged_stop() to simply send SIGTERM to stop munged.  The subsequent sleep is also unnecessary.  Patch attached.  Tested on 11.3-RELEASE-p6 and 12.1-RELEASE-p2.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-02-12 22:00:37 UTC 
A commit references this bug:

Author: bofh
Date: Wed Feb 12 22:00:06 UTC 2020
New revision: 525976
URL: https://svnweb.freebsd.org/changeset/ports/525976

Log:
  security/munge: Fix rc script

  PR:		243917
  Submitted by:	chris.m.dunlap@gmail.com

Changes:
  head/security/munge/Makefile
  head/security/munge/files/munged.in