Created attachment 211928 [details] Sugested svn diff Hello, I can adopt this port. I've found original author site: https://www.unixpapa.com/ and lastest version is 0.11: cursive.c /* CURSIVE SIGNATURE PROGRAM Version 0.11 * (c) 1985 - Jan Wolter This port fetch sources 0.10 but uses PORTVERSION=1.0 and I corrected it to PORTVERSION=0.11 and PORTEPOCH=1 I removed all 3 patch files: => patch-cursive.6 replaced by Makefile post-patch sed => patch-cursive.c included in upstream cursive.c 0.11 => patch-Makefile replaced by Makefile do-build I'm learning how to port/maintain software so any correction would be welcome :) Thanks, Nuno Teixeira
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/120930888
A commit references this bug: Author: fernape Date: Tue Mar 24 17:55:49 UTC 2020 New revision: 529058 URL: https://svnweb.freebsd.org/changeset/ports/529058 Log: games/cursive: Update to 0.11,1 and set MAINTAINER Set PORTVERSION to correct value and set PORTEPOCH accordingly. Set new MAINTAINER (ed.arrakis@gmail.com) PR: 244399 Submitted by: ed.arrakis@gmail.com Changes: head/games/cursive/Makefile head/games/cursive/distinfo head/games/cursive/files/ head/games/cursive/pkg-descr
Committed, Thanks!
Created attachment 225006 [details] games.cursive: upgrade to standard C .. fixed compiler warnings added function prototypes and standard includes
(In reply to Robert McIsaac from comment #4) Hi Robert, Thanks for the patch, however this PR is closed. Before opening a new one, do you think these changes are something the upstream project might be interested in? Cheers
(In reply to Fernando Apesteguía from comment #5) I am new to BSD and interested in contributing so I pick some easy chores for practice. I imagine that "games" have a low priority for the FreeBSD community. My habit is to eliminate compiler warnings from code I work on. If warnings are not fixed, they need to be checked each time the code is compiled. Bugs might be hiding in the stream of trivial warnings. There is a terrific amount of code in the ports tree. Perhaps some of the ports should be deprecated if they are not needed and there is no time to upgrade them.
(In reply to Fernando Apesteguía from comment #5) Hello Fernando, Author of this code is no longer among us but is wife that is a programmer too maybe be interested. In the past I have the idea of puting this program in github so it can continue evolving but I'm not a programmer so I quit that idea. But I will am very happy to apply this patch if you and Robert decide to it. Thanks
(In reply to Robert McIsaac from comment #4) Thanks for patch! I will wait for you and Fernando to decide if it will be applied upstream or in port.
(In reply to Nuno Teixeira from comment #8) Sure thing. I didn't mean to discourage the inclusion of the patch, I just thought the project was still alive. It would be great if someone picks this up and puts it in GH as you suggested. Nevertheless, for the sake of PR database hygiene, we should create a new PR :-)
(In reply to Fernando Apesteguía from comment #9) Yes! Please