Created attachment 211932 [details] Fix comparisons in libraqm As reported in bug 244251, with clang 10.0.0 the print/libraqm port runs into several -Werror warnings: raqm.c:1934:24: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] if (ch != 0x102B || ch != 0x102C || ch != 0x1038 || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1937:25: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <= 0x109A && ch >= 0x109C) || ch != 0x1A61 || ch != 0x1A63 || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1936:41: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] ch != 0x1083 || (ch <= 0x1087 && ch >= 0x108C) || ch != 0x108F || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1935:59: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <= 0x1062 && ch >= 0x1064) || (ch <= 0x1067 && ch >= 0x106D) || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1935:25: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <= 0x1062 && ch >= 0x1064) || (ch <= 0x1067 && ch >= 0x106D) || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ 5 errors generated. The comparisons are clearly invalid as written, and this is most likely due to incorrect boolean inversion done on the negated expression. This problem has been reported upstream too: https://github.com/HOST-Oman/libraqm/issues/115 The attached patch is what I have also proposed upstream.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/125121988
As this is a port where 433 other ports depend on, could we get this fix committed in the tree? :-) print/libraqm (433 skipped) (from the exp-run). Its been about a month now since this PR was initiated. Thanks ahead!
(In reply to Dries Michiels from comment #2) Yeah I'd say commit it. Upstream seems to be dead.
A commit references this bug: Author: zeising Date: Thu Apr 2 15:05:52 UTC 2020 New revision: 530379 URL: https://svnweb.freebsd.org/changeset/ports/530379 Log: print/libraqm: FIx build with llvm 10 Fix the build of print/libraqm with llvm 10. PR: 244401 Submitted by: dim Approved by: maintainer timeout MFH: 2020Q2 Changes: head/print/libraqm/files/patch-src_raqm.c
Committed this, since it breaks so many downstream ports, including ImageMagick and so on. Waiting for MFH
A commit references this bug: Author: zeising Date: Thu Apr 2 18:11:43 UTC 2020 New revision: 530394 URL: https://svnweb.freebsd.org/changeset/ports/530394 Log: MFH: r530379 print/libraqm: FIx build with llvm 10 Fix the build of print/libraqm with llvm 10. PR: 244401 Submitted by: dim Approved by: maintainer timeout Approved by: ports-secteam (joenum) Changes: _U branches/2020Q2/ branches/2020Q2/print/libraqm/files/patch-src_raqm.c
All done, thanks!