Bug 244830 - net-p2p/libtorrent-rasterbar: clang 10 crashes during build
Summary: net-p2p/libtorrent-rasterbar: clang 10 crashes during build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-toolchain (Nobody)
URL: https://bugs.llvm.org/show_bug.cgi?id...
Keywords:
Depends on:
Blocks: 244251
  Show dependency treegraph
 
Reported: 2020-03-15 17:15 UTC by Jan Beich
Modified: 2020-12-12 07:48 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-03-15 17:15:55 UTC
FAILED: CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o
/usr/bin/c++  -DBOOST_ASIO_ENABLE_CANCELIO -DBOOST_ASIO_HAS_STD_CHRONO -DBOOST_EXCEPTION_DISABLE -DTORRENT_BUILDING_LIBRARY -DTORRENT_BUILDING_SHARED -DTORRENT_USE_ICONV -DTORRENT_USE_LIBCRYPTO -DTORRENT_USE_OPENSSL -D_FILE_OFFSET_BITS=64 -Dtorrent_rasterbar_EXPORTS -I/wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/include -I/wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/ed25519/src -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -fvisibility=hidden -fvisibility-inlines-hidden   -Weverything -Wno-documentation -Wno-c++98-compat-pedantic -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -fexceptions -pthread -MD -MT CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o -MF CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o.d -o CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o -c /wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/src/web_connection_base.cpp
Assertion failed: (!empty() && "popping exception stack when not empty"), function popTerminate, file /usr/src/contrib/llvm-project/clang/lib/CodeGen/CGCleanup.h, line 583.
Stack dump:
0.      Program arguments: /usr/bin/c++ -DBOOST_ASIO_ENABLE_CANCELIO -DBOOST_ASIO_HAS_STD_CHRONO -DBOOST_EXCEPTION_DISABLE -DTORRENT_BUILDING_LIBRARY -DTORRENT_BUILDING_SHARED -DTORRENT_USE_ICONV -DTORRENT_USE_LIBCRYPTO -DTORRENT_USE_OPENSSL -D_FILE_OFFSET_BITS=64 -Dtorrent_rasterbar_EXPORTS -I/wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/include -I/wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/ed25519/src -I/usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -Weverything -Wno-documentation -Wno-c++98-compat-pedantic -Wno-padded -Wno-global-constructors -Wno-exit-time-destructors -Wno-weak-vtables -fexceptions -pthread -MD -MT CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o -MF CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o.d -o CMakeFiles/torrent-rasterbar.dir/src/web_connection_base.cpp.o -c /wrkdirs/usr/ports/net-p2p/libtorrent-rasterbar/work/libtorrent-libtorrent-1_2_5/src/web_connection_base.cpp
1.      <eof> parser at end of file
#0 0x0000000003e0ca0e PrintStackTrace /usr/src/contrib/llvm-project/llvm/lib/Support/Unix/Signals.inc:564:13
#1 0x0000000003e0ab95 RunSignalHandlers /usr/src/contrib/llvm-project/llvm/lib/Support/Signals.cpp:69:18
#2 0x0000000003e0eb1e HandleCrash /usr/src/contrib/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:77:5
#3 0x0000000003e0eca1 CrashRecoverySignalHandler /usr/src/contrib/llvm-project/llvm/lib/Support/CrashRecoveryContext.cpp:0:51
#4 0x0000000805034a20 handle_signal /usr/src/lib/libthr/thread/thr_sig.c:0:3
c++: error: clang frontend command failed due to signal (use -v to see invocation)
FreeBSD clang version 10.0.0 (git@github.com:llvm/llvm-project.git llvmorg-10.0.0-rc3-1-gc290cb61fdc)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

http://package18.nyi.freebsd.org/data/headamd64244251-default/2020-02-24_21h29m01s/logs/errors/libtorrent-rasterbar-1.2.4.log
Comment 1 Jan Beich freebsd_committer freebsd_triage 2020-03-15 17:22:52 UTC
Over to toolchain@ to bisect/report upstream. No rush to workaround -CURRENT regressions.

Cannot attach Clang dump of *compressed* preprocessed file:
> The file you are trying to attach is 1295 kilobytes (KB) in size. Attachments cannot be more than 1000 KB.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-03-31 05:41:55 UTC
A commit references this bug:

Author: yuri
Date: Tue Mar 31 05:02:03 UTC 2020
New revision: 529947
URL: https://svnweb.freebsd.org/changeset/ports/529947

Log:
  net-p2p/libtorrent-rasterbar: Force clang-9 because clang-10 fails

  PR:		244830
  Reported by:	fallout

Changes:
  head/net-p2p/libtorrent-rasterbar/Makefile
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2020-04-19 19:37:56 UTC
Added the upstream clang bug report.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-04-20 17:40:38 UTC
A commit references this bug:

Author: dim
Date: Mon Apr 20 17:39:52 UTC 2020
New revision: 360129
URL: https://svnweb.freebsd.org/changeset/base/360129

Log:
  Merge commit ce5173c0e from llvm git (by Reid Kleckner):

    Use FinishThunk to finish musttail thunks

    FinishThunk, and the invariant of setting and then unsetting
    CurCodeDecl, was added in 7f416cc42638 (2015). The invariant didn't
    exist when I added this musttail codepath in ab2090d10765 (2014).
    Recently in 28328c3771, I started using this codepath on non-Windows
    platforms, and users reported problems during release testing
    (PR44987).

    The issue was already present for users of EH on i686-windows-msvc,
    so I added a test for that case as well.

    Reviewed By: hans

    Differential Revision: https://reviews.llvm.org/D76444

  This should fix 'Assertion failed: (!empty() && "popping exception stack
  when not empty"), function popTerminate, file
  /usr/src/contrib/llvm-project/clang/lib/CodeGen/CGCleanup.h, line 583'
  when building the net-p2p/libtorrent-rasterbar

  PR:		244830
  Reported by:	jbeich, yuri
  MFC after:	6 weeks
  X-MFC-With:	358851

Changes:
  head/contrib/llvm-project/clang/lib/CodeGen/CGVTables.cpp
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2020-12-12 01:29:05 UTC
Can this be closed?
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-12-12 07:47:59 UTC
A commit references this bug:

Author: jbeich
Date: Sat Dec 12 07:47:44 UTC 2020
New revision: 557802
URL: https://svnweb.freebsd.org/changeset/ports/557802

Log:
  net-p2p/libtorrent-rasterbar: drop clang workaround (reverting r529947)

  Old -CURRENT snapshots are not supported while Clang assertions
  are disabled on FreeBSD -RELEASEs and -STABLE branches.

  PR:		244830

Changes:
  head/net-p2p/libtorrent-rasterbar/Makefile