Bug 245094 - deskutils/lookbook: Update to 1.1.0
Summary: deskutils/lookbook: Update to 1.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/danrabbit/lookbook...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-03-27 09:56 UTC by Olivier Duchateau
Modified: 2020-03-27 23:00 UTC (History)
2 users (show)

See Also:
val: maintainer-feedback+

Attachments
Patch to update deskutils/lookbook (91.65 KB, patch)
2020-03-27 09:56 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2020-03-27 09:56:01 UTC 
Created attachment 212746 [details]
Patch to update deskutils/lookbook

- Update to 1.1.0
- Remove patch (tested with Vala 0.40.18, bug #243491)
- Remove BINARY_ALIAS line, build is fine with Meson 0.53.x)
Comment 1 Automation User 2020-03-27 10:35:22 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/130307064
Comment 2 Val Packett 2020-03-27 12:10:32 UTC 
LGTM
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-03-27 18:33:02 UTC 
A commit references this bug:

Author: fernape
Date: Fri Mar 27 18:12:40 UTC 2020
New revision: 529276
URL: https://svnweb.freebsd.org/changeset/ports/529276

Log:
  deskutils/lookbook: Update to 1.1.0

  ChangeLog: https://github.com/danrabbit/lookbook/releases/tag/1.1.0

  Better support for symbolic-only icons and under the hood improvements

  PR:	245094
  Submitted by:	duchateau.olivier@gmail.com
  Reviewed by:e
  Approved by:	greg@unrelenting.technology (maintainer)

Changes:
  head/deskutils/lookbook/Makefile
  head/deskutils/lookbook/distinfo
  head/deskutils/lookbook/files/
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2020-03-27 19:05:55 UTC 
Committed,

Thanks!
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-03-27 19:07:31 UTC 
Hi Greg,

The name of most of the files in pkg-plist look weird, especially the main executable (com.github.danrabbit.lookbook) Have you consider changing it?

Cheers
Comment 6 Val Packett 2020-03-27 23:00:03 UTC 
(In reply to Fernando Apesteguía from comment #5)

> The name of most of the files in pkg-plist look weird, especially the main executable (com.github.danrabbit.lookbook) Have you consider changing it?

No, I'm not going to change the name it installs as.

This is actually the new cool thing to do, popularized by elementary OS especially. Makes sense to me, GUI apps' executable names aren't necessarily meant to be launched from the console often. Matching the executable to the same reverse-dns convention as .desktop files, icons and D-Bus objects is good.