Bug 245166 - emulators/fceux: fix missing dependency on graphics/gdk-pixbuf2
Summary: emulators/fceux: fix missing dependency on graphics/gdk-pixbuf2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2020-03-29 15:16 UTC by Andy Mender
Modified: 2020-03-31 16:04 UTC (History)
2 users (show)

See Also:

Attachments
Makefile diff (330 bytes, patch)
2020-03-29 15:16 UTC, Andy Mender 		no flags Details | Diff
Makefile diff (595 bytes, patch)
2020-03-30 18:20 UTC, Andy Mender 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Mender 2020-03-29 15:16:02 UTC 
Created attachment 212833 [details]
Makefile diff

When installing the emulators/fceux port, make shows the following warning:
```
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/fceux is linked to /usr/local/lib/libgdk_pixbuf-2.0.so.0 from graphics/gdk-pixbuf2 but it is not declared as a dependency
Warning: you need USE_GNOME+=gdkpixbuf2
```

The attached svnlite diff adds the missing line to the port's Makefile. Should I also bump PORTREVISION?
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2020-03-30 11:09:44 UTC 
Yes, please.

No ports will be rebuilt if you bump PORTREVISION, so it will be a minimum disturbance.

$ find . -name Makefile -exec grep -H fceux {} \;
./emulators/Makefile:    SUBDIR += fceux
./emulators/fceux/Makefile:# $FreeBSD: head/emulators/fceux/Makefile 517045 2019-11-08 10:08:49Z tobik $
./emulators/fceux/Makefile:PORTNAME=    fceux
./emulators/fceux/Makefile:              s|/usr/share/|${PREFIX}/share/|' ${WRKSRC}/fceux.desktop
./emulators/fceux/Makefile:.for i in fceux fceux-net-server
Comment 2 Andy Mender 2020-03-30 18:20:00 UTC 
Created attachment 212870 [details]
Makefile diff

Adding a new diff with an update to PORTREVISION. I also created it from the top of the ports tree, following the guidelines in the Porter's Handbook.
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2020-03-31 10:43:32 UTC 
(In reply to Andy Mender from comment #2)

Excellent,
Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-03-31 16:03:40 UTC 
A commit references this bug:

Author: fernape
Date: Tue Mar 31 16:02:58 UTC 2020
New revision: 529983
URL: https://svnweb.freebsd.org/changeset/ports/529983

Log:
  emulators/fceux: Fix missing dependency on graphics/gdk-pixbuf2

  PR:	245166
  Submitted by:	andymenderunix@gmail.com

Changes:
  head/emulators/fceux/Makefile
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2020-03-31 16:04:31 UTC 
Committed,

Thanks!