Bug 245356 - net-p2p/torrent-file-editor: PCH will not work with CMake 3.17
Summary: net-p2p/torrent-file-editor: PCH will not work with CMake 3.17
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-04 18:44 UTC by Adriaan de Groot
Modified: 2020-06-14 13:19 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adriaan de Groot freebsd_committer freebsd_triage 2020-04-04 18:44:46 UTC 
With PCH enabled, CMake 3.17 chokes on this port during configure,

CMake Error at /wrkdirs/usr/ports/net-p2p/torrent-file-editor/work/torrent-file-editor-0.3.17/cmake/CompilePch.cmake:102 (message):
  Can't parse compile command for
  /wrkdirs/usr/ports/net-p2p/torrent-file-editor/work/.build/qrc_resources.cpp:
  No such file or directory

The easiest fix is to disable PCH so the port builds again:

Index: Makefile
===================================================================
--- Makefile    (revision 530705)
+++ Makefile    (working copy)
@@ -16,7 +16,8 @@
 USE_QT=                buildtools_build linguisttools_build qmake_build \
                core gui widgets
 
-CMAKE_ARGS=    -DQT5_BUILD:BOOL=ON
+CMAKE_ARGS=    -DQT5_BUILD:BOOL=ON \
+               -DENABLE_PCH:BOOL=OFF
 
 OPTIONS_DEFINE=        DONATION
 OPTIONS_DEFAULT=       DONATION
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-04-05 11:12:08 UTC 
A commit references this bug:

Author: adridg
Date: Sun Apr  5 11:11:00 UTC 2020
New revision: 530765
URL: https://svnweb.freebsd.org/changeset/ports/530765

Log:
  net-p2p/torrent-file-editor turn off PCH (pre-compiled headers)

  This is prep-work to landing CMake 3.17 -- something has changed in
  dependency handling, and the configure step fails. This is the
  last fall-out item before a new exp-run.

  PR:		245356

Changes:
  head/net-p2p/torrent-file-editor/Makefile
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2020-04-05 13:05:44 UTC 
I'm sorry, but why did you open this PR and assigned it to the maintainer if you indented to make the commit yourself in less than 24 hours?
Comment 3 Adriaan de Groot freebsd_committer freebsd_triage 2020-06-14 13:19:36 UTC 
Communications confusion on my part, whether "fix build in advance of cmake updates so that the fix stays out of the exp-run" should be PR'ed or not.