Bug 245379 - games/py-pychess: Restore port
Summary: games/py-pychess: Restore port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mikhail Teterin
URL:
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2020-04-05 17:30 UTC by Mikhail Teterin
Modified: 2020-04-08 13:40 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (python)

Attachments
pychess-1.0.0 (3.28 KB, patch)
2020-04-05 17:30 UTC, Mikhail Teterin 		no flags Details | Diff
pychess-1.0.0 (4.81 KB, patch)
2020-04-05 17:33 UTC, Mikhail Teterin 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2020-04-05 17:30:43 UTC 
Created attachment 213102 [details]
pychess-1.0.0

This brings games/py-pychess back from the dark.

Please, review, if I've got all of the USE_* knobs correctly.

Upstream's setup.py crashes without DISPLAY -- I contacted them about it, but for now, that's a requirement.

The patch is against ports rt371287 -- the last version before the old port was marked BROKEN and deleted in 2015.
Comment 1 Mikhail Teterin freebsd_committer freebsd_triage 2020-04-05 17:33:08 UTC 
Created attachment 213103 [details]
pychess-1.0.0
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2020-04-07 20:26:00 UTC 
Fix Cc: .
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-08 00:03:38 UTC 
^Triage: Reporter is committer, assign accordingly

@Mikhail Does this otherwise already pass QA (portlint, poudriere, etc) ?
Comment 4 Mikhail Teterin freebsd_committer freebsd_triage 2020-04-08 01:34:29 UTC 
(In reply to Kubilay Kocak from comment #3)
> @Mikhail Does this otherwise already pass QA (portlint, poudriere, etc)?

No idea. Nothing depends on this port (obviously), so, if others don't see glaring errors, I'll just re-add it and wait for fallout, expecting none...
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2020-04-08 07:08:02 UTC 
(In reply to Mikhail Teterin from comment #4)
> No idea.

So, you have not even test built it to see how it goes, or run portlint, portfmt, portclippy to tell you how you could improve it?
Comment 6 Mikhail Teterin freebsd_committer freebsd_triage 2020-04-08 13:33:27 UTC 
(In reply to Mathieu Arnold from comment #5)
> So, you have not even test built it to see how it goes, or run portlint

Of course, I did -- test-built on two different machines (12.1/i386 and 11.3/amd64) and portlint-ed. It is "poudriere", which I haven't attempted.

Given the sudden rise of toxicity, I'm closing this ticket and will let our automated processes deal with the port.

Thanks, all!
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-04-08 13:40:19 UTC 
A commit references this bug:

Author: mi
Date: Wed Apr  8 13:39:44 UTC 2020
New revision: 531116
URL: https://svnweb.freebsd.org/changeset/ports/531116

Log:
  Bring pychess -- new version -- back from the void.

  Take maintainership.

  PR:		245379
  Submitted by:	self

Changes:
  head/games/py-pychess/
  head/games/py-pychess/Makefile
  head/games/py-pychess/distinfo
  head/games/py-pychess/files/
  head/games/py-pychess/files/patch-setup
  head/games/py-pychess/pkg-message