Bug 245502 - net/ntpsec: missing asciidoc dependency
Summary: net/ntpsec: missing asciidoc dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-10 11:37 UTC by Dmitry Marakasov
Modified: 2020-04-10 15:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2020-04-10 11:37:58 UTC 
FYI, I've fixed plist generation wrt new manpage path, see r531317.

And another problem is that the build system has optional dependencies which are not listed in the port, namely asciidoc. It's absence when package is built leads to missing manpages, and it's optional presence on user host leads to inconsistent package contents.

Also I'd advice against fully dynamic plist as it allows problems like this one to be missed. You can generate plist dynamically for python part only, leaving binaries and manpages in static plist.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-04-10 15:47:46 UTC 
A commit references this bug:

Author: yuri
Date: Fri Apr 10 15:47:03 UTC 2020
New revision: 531325
URL: https://svnweb.freebsd.org/changeset/ports/531325

Log:
  net/ntpsec: Fix build; Add missing dependencies asciidoc and mDNSResponder; Correct LICENSE

  PR:		245503 245502
  Reported by:	amdmi3 gelonnov@gmail.com

Changes:
  head/net/ntpsec/Makefile
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2020-04-10 15:47:51 UTC 
Fix committed, thanks!