Created attachment 213272 [details] Patch to 0.8.0 Update to 0.8.0. Port changelog: - use cmake build system - added textproc/asciidoc build depend - use xrandr - remove shell completions option as Porter's Handbook suggests Program changelog (https://herbstluftwm.org/news.html): - single window floating (every client has an attribute floating which can be set at run time and via the rule consequence floating=on) - monitor detection via xrandr - detection of external panels - new commands: apply_rules, drag, export - new client attribute: keys_inactive (negation of keymask) - some minor improvements and bug fixes
Moin moin fails to compile on current for me: FAILED: src/CMakeFiles/herbstluftwm.dir/completion.cpp.o /usr/local/libexec/ccache/c++ -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -std=gnu++11 -MD -MT src/CMakeFiles/herbstluftwm.dir/completion.cpp.o -MF src/CMakeFiles/herbstluftwm.dir/completion.cpp.o.d -o src/CMakeFiles/herbstluftwm.dir/completion.cpp.o -c /wrkdirs/usr/ports/x11-wm/herbstluftwm/work/herbstluftwm-0.8.0/src/completion.cpp /wrkdirs/usr/ports/x11-wm/herbstluftwm/work/herbstluftwm-0.8.0/src/completion.cpp:38:33: error: invalid operands to binary expression ('basic_ostream<char, std::__1::char_traits<char> >' and 'const char *') output_ << escape(word) << (shellOutput_ ? " \n" : "\n"); ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/c++/v1/memory:5020:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-2>' against 'const char *' operator<<(basic_ostream<_CharT, _Traits>& __os, shared_ptr<_Yp> const& __p); ^ /usr/include/c++/v1/string_view:774:1: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'const char *' operator<<(basic_ostream<_CharT, _Traits>& __os, ^ /usr/include/c++/v1/string:4250:1: note: candidate template ignored: could not match 'basic_string<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2>' against 'const char *' operator<<(basic_ostream<_CharT, _Traits>& __os, ^ /wrkdirs/usr/ports/x11-wm/herbstluftwm/work/herbstluftwm-0.8.0/src/completion.cpp:75:33: error: invalid operands to binary expression ('basic_ostream<char, std::__1::char_traits<char> >' and 'const char [2]') output_ << escape(word) << "\n"; ~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~ /usr/include/c++/v1/memory:5020:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-2>' against 'char const[2]' operator<<(basic_ostream<_CharT, _Traits>& __os, shared_ptr<_Yp> const& __p); ^ /usr/include/c++/v1/string_view:774:1: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'const char *' operator<<(basic_ostream<_CharT, _Traits>& __os, ^ /usr/include/c++/v1/string:4250:1: note: candidate template ignored: could not match 'basic_string<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2>' against 'char const[2]' operator<<(basic_ostream<_CharT, _Traits>& __os, ^ 2 errors generated. mfg Tobias
Created attachment 213284 [details] Inlude completion.cpp patch Sorry, I forgot add a new patch. It should work now.
===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: /etc/bash_completion.d/herbstclient-completion Error: Orphaned: /etc/xdg/herbstluftwm/autostart Error: Orphaned: /etc/xdg/herbstluftwm/dmenu_run_hlwm Error: Orphaned: /etc/xdg/herbstluftwm/panel.sh Error: Orphaned: /etc/xdg/herbstluftwm/restartpanels.sh Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/LICENSE Error: Orphaned: share/man/man1/herbstclient.1.gz Error: Orphaned: share/man/man1/herbstluftwm.1.gz Error: Orphaned: share/man/man7/herbstluftwm-tutorial.7.gz Error: Orphaned: @dir /etc/bash_completion.d Error: Orphaned: @dir /etc/xdg/herbstluftwm Error: Orphaned: @dir /etc/xdg ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: etc/bash_completion.d/herbstclient-completion Error: Missing: etc/xdg/herbstluftwm/autostart Error: Missing: etc/xdg/herbstluftwm/dmenu_run_hlwm Error: Missing: etc/xdg/herbstluftwm/panel.sh Error: Missing: etc/xdg/herbstluftwm/restartpanels.sh Error: Missing: man/man1/herbstclient.1.gz Error: Missing: man/man1/herbstluftwm.1.gz Error: Missing: man/man7/herbstluftwm-tutorial.7.gz ===> Error: Plist issues found.
Moin moin Please ensure that your upgrades work fine inside poudriere :) mfg Tobias
Created attachment 213341 [details] updated updated patch It worked but I forget "svn add files/patch-..." before "svn diff". Now (I hope) it contains every new file/patch... :)
(In reply to Zsolt Udvari from comment #5) We'll see :D
Committed. Thanks.
A commit references this bug: Author: tcberner Date: Sun Apr 12 19:20:31 UTC 2020 New revision: 531548 URL: https://svnweb.freebsd.org/changeset/ports/531548 Log: x11-wm/herbstluftwm update to 0.8.0 Port changelog: - use cmake build system - added textproc/asciidoc build depend - use xrandr - remove shell completions option as Porter's Handbook suggests Program changelog (https://herbstluftwm.org/news.html): - single window floating (every client has an attribute floating which can be set at run time and via the rule consequence floating=on) - monitor detection via xrandr - detection of external panels - new commands: apply_rules, drag, export - new client attribute: keys_inactive (negation of keymask) - some minor improvements and bug fixes PR: 245527 Submitted by: Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer) Changes: head/x11-wm/herbstluftwm/Makefile head/x11-wm/herbstluftwm/distinfo head/x11-wm/herbstluftwm/files/patch-CMakeLists.txt head/x11-wm/herbstluftwm/files/patch-share_autostart head/x11-wm/herbstluftwm/files/patch-src_completion.cpp head/x11-wm/herbstluftwm/pkg-plist