Created attachment 213612 [details] The new port Please add Yamagi Quake II. This is the most advanced (in my opinion) port of Quake2. It uses SDL2 and therefore can be run in Wayland without any additional tweaks.
I'll handle this one (being maintainer of the other Quake II ports).
danfe@ : ping? This has been languishing, but (quick eyeballing) seems plausible.
The build fails due to a duplicate symbol error during linking. http://pkg.ftfl.ca/data/14amd64-default/2022-03-24_14h55m55s/logs/errors/yquake2-7.43.log
Adriaan, Joseph, thanks for prodding, can't tell why I haven't committed it earlier while it's been sitting in my local tree for a while, will do shortly.
Created attachment 232689 [details] Version 8.0
Can you please commit an updated version then? Also removed obsolete $FreeBSD: $ from Makefile.
poudriere testport -j 13amd64 ... looks good now. I created a review with some tweaks at https://reviews.freebsd.org/D34670 - Remove deprecated #Created by:... (you will be author of commit) - Add missing entry in games/Makefile - Set DISTVERSIONPREFIX/DISTVERSION to upstream release - Remove redundant GITHUB variables - Formatting: Run through portclippy/portfmt/portlint
(In reply to shamaz.mazum from comment #6) > Can you please commit an updated version then? Certainly, I'll commit recently released version 8.01.
danfe, before you commit, please look at the review that I posted.
(In reply to Joseph Mingrone from comment #7) > - Remove deprecated #Created by:... (you will be author of commit) Well, no, I'm afraid he won't, given the amount of modifications I had to make. :-) Original port submission was quite unpolished (which is fine, all the leg-work was there). > - Set DISTVERSIONPREFIX/DISTVERSION to upstream release > - Remove redundant GITHUB variables These are not needed, just as using GitHub at all: upstream provides proper source release tarball. > - Formatting: Run through portclippy/portfmt/portlint There are more bugs other than stylish ones: wrong usage of LIB_DEPENDS for dlopen'ed library, bogus OPTIONS_SUB, needless `post-patch' target, easily avoidable CONFLICTS_INSTALL, CMake is deprecated upstream, documentation not being installed, etc.
I'm glad you found time for an exhaustive look.
(In reply to Alexey Dokuchaev from comment #10) Is there a rule that I must avoid post-patch target? And what does that mean "CMake is deprecated upstream"?
(In reply to shamaz.mazum from comment #12) > Is there a rule that I must avoid post-patch target? There's no hard rule, but naturally passing variables down via MAKE_ARGS is preferred to patching files with sed(1). > And what does that mean "CMake is deprecated upstream"? From the CMakeLists.txt: # Print a message that using the Makefiles is recommended. message(NOTICE: " The CMakeLists.txt is unmaintained. Use the Makefile if possible.")
(In reply to Alexey Dokuchaev from comment #13) https://github.com/yquake2/yquake2/commit/cd641cfb9a5ebbc196e5bbbb57dc62cb3f893f23 Not so unmaintained. Last commit 8 days ago.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=37eb44cc9bb29b78ce13879e4f8d673f02524879 commit 37eb44cc9bb29b78ce13879e4f8d673f02524879 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2022-03-25 12:44:18 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2022-03-25 12:44:18 +0000 games/yquake2: new port had been added (Yamagi Quake II) Yamagi Quake II is advanced port of Icculus Quake II. It uses SDL2 and therefore can be run in Wayland without any additional tweaks. PR: 245770 (modified) games/Makefile | 1 + games/yquake2/Makefile (new) | 45 ++++++++++++++++++++++ games/yquake2/distinfo (new) | 3 ++ games/yquake2/files/patch-Makefile (new) | 28 ++++++++++++++ .../yquake2/files/patch-src_client_vid_vid.c (new) | 17 ++++++++ .../files/patch-src_common_filesystem.c (new) | 12 ++++++ games/yquake2/pkg-descr (new) | 9 +++++ games/yquake2/pkg-plist (new) | 16 ++++++++ 8 files changed, 131 insertions(+)
(In reply to shamaz.mazum from comment #14) > Not so unmaintained. Last commit 8 days ago. Good developers try to keep even deprecated stuff working. :-) It does not mean we shouldn't trust the warning. Also, CMake is much heavier dependency than GNU make.
Oh, wonderful. Thanks!