Bug 245871 - print/lyx: build with py-3.7
Summary: print/lyx: build with py-3.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-04-24 12:12 UTC by Kurt Jaeger
Modified: 2020-05-11 11:09 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback+

Attachments
patch (6.87 KB, patch)
2020-04-24 12:12 UTC, Kurt Jaeger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2020-04-24 12:12:55 UTC 
Created attachment 213745 [details]
patch

TODO: run-tests
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2020-04-24 16:30:57 UTC 
run-test is fine according to one user:

https://lists.freebsd.org/pipermail/freebsd-ports/2020-April/118354.html
Comment 2 Steve Wills freebsd_committer freebsd_triage 2020-05-11 09:31:57 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/144526687
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2020-05-11 09:48:54 UTC 
Comment on attachment 213745 [details]
patch

Sorry it took a while to respond.

- You need to bump PORTREVISION due to the plist and dependency changes.
- You shouldn't hardcode the Python version ("37") in the plist, but use %%PYTHON_SUFFIX%% instead (see accessibility/orca, for example).
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2020-05-11 11:09:02 UTC 
Committed, thanks all!
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-05-11 11:09:16 UTC 
A commit references this bug:

Author: pi
Date: Mon May 11 11:08:49 UTC 2020
New revision: 534906
URL: https://svnweb.freebsd.org/changeset/ports/534906

Log:
  print/lyx: fix build with python-3.7

  - https://www.lyx.org/trac/ticket/9006 says that lyx works with py3
  - run-test done by reviewer

  PR:		245871
  Reviewed by:	starikarp@dismail.de
  Approved by:	rakuco (maintainer)

Changes:
  head/print/lyx/Makefile
  head/print/lyx/pkg-descr
  head/print/lyx/pkg-plist