Created attachment 213962 [details] update darktable from 3.0.0 to 3.0.2 update darktable from 3.0.0 to 3.0.2 Hi, find attached an upgrade for darktable from 3.0.0 to 3.0.2 Additional changes: - export to Flickr, Facebook and Google Photo removed as it is no longer supported in 3.0.2 Compiled on 12.1 amd64 live system (jail), a few tests performed with a Nikon NEF image
I figured that for the current cmake versions, I need to rename the iterator/loop variable in data/kernels/CMakeLists.txt around ll. 34ff. - IN is special, and two places need to rename it to i. New patch coming up.
Created attachment 214275 [details] update darktable 3.0.0_3 to 3.0.2, replaces Ludger's patch - add a patch to prevent cmake failure for data/kernels/CMakeLists.txt - rediff patches - reshuffle Makefile per portclippy recommendation - remove COLORD option, it's not technically required to build, but a raw processing application without color management does not make sense. It was default anyways.
Created attachment 214319 [details] revised version 3 of patch, omitting the build fix The build fix was committed already on head/ as r534788 and MFH'd to 2020Q2 as r534789. This patch omits that part. files/patch-data_kernels_CMakeLists.txt needs to remain after the 3.0.2 update!
Hi! Sorry for the lack of responsiveness. I'm testing the patch tonight and will get back to you quickly.
The patch works for me. Feel free to commit it! Thank you to both of you for the work!
A commit references this bug: Author: mandree Date: Wed May 13 12:05:36 UTC 2020 New revision: 535105 URL: https://svnweb.freebsd.org/changeset/ports/535105 Log: graphics/darktable: update to 3.0.2 This is an upgrade for darktable from 3.0.0 to 3.0.2, with Ludger's changes from the original PR submission: - export to Flickr, Facebook and Google Photo removed as [they are] no longer supported in 3.0.2 And these changes by mandree@: - rediff patches - reshuffle Makefile per portclippy recommendation - remove COLORD option, it's not technically required to build, but a a raw image processing application without color management makes little sense. This option was default-on anyways. Changes 3.0.0 -> 3.0.1: https://www.darktable.org/2020/03/darktable-301-released/ https://github.com/darktable-org/darktable/releases/tag/release-3.0.1 Changes 3.0.1 -> 3.0.2: https://www.darktable.org/2020/04/darktable-302-released/ https://github.com/darktable-org/darktable/releases/tag/release-3.0.2 PR: 246065 Submitted by: Ludger Bolmerg <lbolmerg@posteo.de> Approved by: Jean-S?bastien P?dron <dumbbell@> (maintainer) Changes: head/graphics/darktable/Makefile head/graphics/darktable/distinfo head/graphics/darktable/files/patch-src_CMakeLists.txt head/graphics/darktable/files/patch-src_external_rawspeed_cmake_Modules_CheckZLIB.cmake head/graphics/darktable/pkg-plist
Comment on attachment 214319 [details] revised version 3 of patch, omitting the build fix switch maintainer-approval to + per comment #5.