Bug 246147 - mail/postfixadmin: Update to 3.2.4
Summary: mail/postfixadmin: Update to 3.2.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Tagato
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-03 18:25 UTC by Phillip R. Jaenke
Modified: 2020-05-14 05:14 UTC (History)
2 users (show)

See Also:
ports.maintainer: maintainer-feedback+


Attachments
Update to 3.2.4, switch to GitHub (1.15 KB, patch)
2020-05-03 18:25 UTC, Phillip R. Jaenke
no flags Details | Diff
Update to 3.2.4, switch to github (revised) (1.15 KB, patch)
2020-05-04 11:20 UTC, ports.maintainer
ports.maintainer: maintainer-approval-
Details | Diff
patch revised per comment #3 (1.27 KB, patch)
2020-05-13 10:37 UTC, ports.maintainer
ports.maintainer: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Phillip R. Jaenke 2020-05-03 18:25:42 UTC
Created attachment 214068 [details]
Update to 3.2.4, switch to GitHub

postfixadmin development has become quite active again, necessitating an update here. Particularly included between 3.2 and 3.2.4 are fixes for SQLite and MySQL SSL connections. Active development and releases have also moved to GitHub from SourceForge.

Attached patch updates to 3.2.4 and switches to GitHub.
Comment 1 ports.maintainer 2020-05-04 11:20:12 UTC
Created attachment 214104 [details]
Update to 3.2.4, switch to github (revised)

Thanks for the heads up!  Patch revised slightly to meet file structure guidelines.

Tested with poudriere.
Comment 2 ports.maintainer 2020-05-04 11:21:33 UTC
Comment on attachment 214068 [details]
Update to 3.2.4, switch to GitHub

Good update, but the lines in Makefile need to be in a different order.  See revised patch.
Comment 3 Hiroki Tagato freebsd_committer freebsd_triage 2020-05-12 08:02:32 UTC
Hi,

I guess you're using GH_TAGNAME because the tag on GitHub is prefixed with 'postfixamin-'.

In this case, you can write like:

DISTVERSIONPREFIX= postfixadmin-
DISTVERSION= 3.2.4

and no GH_TAGNAME is required. (I think this is easier for maintaining.)

Can you update the patch accordingly?
Comment 4 ports.maintainer 2020-05-13 10:35:19 UTC
(In reply to Hiroki Tagato from comment #3)

I left it the way Phillip submitted it because it works and matched the form in Example 5.11 in the Porter's Handbook.  Updated patch incoming.
Comment 5 ports.maintainer 2020-05-13 10:37:27 UTC
Created attachment 214447 [details]
patch revised per comment #3
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-05-14 05:13:17 UTC
A commit references this bug:

Author: tagattie
Date: Thu May 14 05:12:35 UTC 2020
New revision: 535201
URL: https://svnweb.freebsd.org/changeset/ports/535201

Log:
  - Update to 3.2.4
  - Move to GitHub

  PR:		246147
  Submitted by:	Phillip R. Jaenke <prj@rootwyrm.com>,
  		Rin Morningstar <ports.maintainer@evilphi.com> (maintainer)
  Approved by:	ehaupt (mentor)
  Changelog:	https://github.com/postfixadmin/postfixadmin/releases/tag/postfixadmin-3.2.4

Changes:
  head/mail/postfixadmin/Makefile
  head/mail/postfixadmin/distinfo
Comment 7 Hiroki Tagato freebsd_committer freebsd_triage 2020-05-14 05:14:09 UTC
Committed, thanks!