Bug 246290 - textproc/ripgrep: do install completion file for fish
Summary: textproc/ripgrep: do install completion file for fish
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-07 17:47 UTC by Alan Somers
Modified: 2020-05-07 20:43 UTC (History)
1 user (show)

See Also:
petteri.valkonen: maintainer-feedback+


Attachments
Install rg.fish (1.03 KB, patch)
2020-05-07 17:47 UTC, Alan Somers
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2020-05-07 17:47:17 UTC
Created attachment 214240 [details]
Install rg.fish

To solve bug 244355, we stopped installing the completion file for fish, because fish installed it itself.  Now fish has stopped doing that, and they request that packages like ripgrep install it themselves.  But we are to install it into a different directory than we used to.  The attached patch puts it into the new location.

https://github.com/fish-shell/fish-shell/issues/5822
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-05-07 20:40:03 UTC
A commit references this bug:

Author: asomers
Date: Thu May  7 20:39:41 UTC 2020
New revision: 534289
URL: https://svnweb.freebsd.org/changeset/ports/534289

Log:
  textproc/ripgrep: do install completion file for fish

  To solve bug 244355, we stopped installing the completion file for fish,
  because fish installed it itself.  Now fish has stopped doing that, and they
  request that packages like ripgrep install it themselves.  But we are to
  install it into a different directory than we used to.  This change puts it
  into the new location.

  PR:		246290
  Approved by:	petteri.valkonen@iki.fi (maintainer)

Changes:
  head/textproc/ripgrep/Makefile