Bug 246729 - devel/py-pyflakes: Update to 2.2.0
Summary: devel/py-pyflakes: Update to 2.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-05-25 21:50 UTC by Dmitry Marakasov
Modified: 2020-06-09 06:06 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+


Attachments
patch (807 bytes, patch)
2020-05-25 21:50 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2020-05-25 21:50:32 UTC
Created attachment 214855 [details]
patch

- Update to 2.2.0

Note that this should be committed along with flake8 update which requires specific versions of pyflakes, I can commit them together if this is approved.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-05-26 01:23:56 UTC
Thank you Dmitry

Could you add an issue for the flake8 update and link that issue to this issue's "Blocks" field as well 

Also, does this update pass QA (poudriere and make test) ? In particular the 2.2.0 release notes mention: "Switch from optparse to argparse"

The test suite should be confirmed to run and pass in poudriere jails on 2.x and 3.x
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2020-05-26 11:30:14 UTC
> Could you add an issue for the flake8 update and link that issue to this issue's "Blocks" field as well 

I do not plan to open issues for updates of my own ports.

> Also, does this update pass QA (poudriere and make test) ? In particular the 2.2.0 release notes mention: "Switch from optparse to argparse"

> The test suite should be confirmed to run and pass in poudriere jails on 2.x and 3.x

Of course it does.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2020-05-26 16:48:32 UTC
(In reply to Dmitry Marakasov from comment #2)

> Of course it does.

(tests as well)
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-08 22:16:40 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Jun  8 22:15:36 UTC 2020
New revision: 538261
URL: https://svnweb.freebsd.org/changeset/ports/538261

Log:
  - Update to 2.2.0

  PR:		246729
  Submitted by:	amdmi3
  Approved by:	maintainer timeout (koobs, 2 weeks)

Changes:
  head/devel/py-pyflakes/Makefile
  head/devel/py-pyflakes/distinfo
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-09 06:06:26 UTC
(In reply to commit-hook from comment #4)

I wasn't expecting a maintainer timeout in this case, but I understand that 2 weeks have passed since my last bug ack, so it was 'technically' appropriate.

I should have reassigned this to you after starting QA on my end, or at least mentioned that I was doing additional QA

In future feel free to ping/comment on any issue before committing under maintainer timeout, especially for anything that's blocking work at your end.

In this case I would have approved/reassigned after checking my local QA work again.

Lastly, when committing/resolving issues that are currently assigned to someone else, don't forget to self-assign it to 'complete the loop'.

^Triage: Assign to committer that resolved