Bug 246872 - devel/golangci-lint: Fix build error as reported by pkg-fallout
Summary: devel/golangci-lint: Fix build error as reported by pkg-fallout
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlo Strub
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-30 15:29 UTC by Lewis Cook
Modified: 2020-06-08 19:47 UTC (History)
1 user (show)

See Also:

Attachments
golangci-lint-1.27.0_1.diff (1.45 KB, patch)
2020-05-30 15:29 UTC, Lewis Cook 		lcook: maintainer-approval+
Details | Diff
golangci-lint-1.27.0_1.log (38.84 KB, text/plain)
2020-05-30 15:30 UTC, Lewis Cook 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-05-30 15:29:57 UTC 
Created attachment 215060 [details]
golangci-lint-1.27.0_1.diff

Amended:
 * Since the env variable '$HOME' is being set to
   '/nonexistent' this will cause build errors for
   non-privileged users. Work-around this by setting
   the necessary work environment (which includes $HOME).
   This was reported by pkg-fallout. [1]
 * Minor semantic changes in a few places.
 * Bumped PORTREVISION.

1: http://package19.nyi.freebsd.org/data/121amd64-default-build-as-user/536823/logs/errors/golangci-lint-1.27.0.log 

Tested:
 * portlint: OK (looks fine).
 * testport: OK (poudriere: 3.3.4).
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2020-05-30 15:30:35 UTC 
Created attachment 215061 [details]
golangci-lint-1.27.0_1.log

* Poudriere testport log.
Comment 2 Automation User 2020-05-30 15:36:35 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151196445
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-06-08 19:47:07 UTC 
A commit references this bug:

Author: cs
Date: Mon Jun  8 19:46:50 UTC 2020
New revision: 538248
URL: https://svnweb.freebsd.org/changeset/ports/538248

Log:
  Amended:
   * Since the env variable '$HOME' is being set to
     '/nonexistent' this will cause build errors for
     non-privileged users. Work-around this by setting
     the necessary work environment (which includes $HOME).
     This was reported by pkg-fallout. [1]
   * Minor semantic changes in a few places.
   * Bumped PORTREVISION.

  PR:		246872
  Submitted by:	maintainer

Changes:
  head/devel/golangci-lint/Makefile