Created attachment 215150 [details] Patch against current ports. Update to latest upstream. Remove the extra patches as they are incorporated upstream and change from EXTRA_PATCHES to CONFIGURE_ARGS for the PORT_OPTIONS.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151755877
Thank you for your patch! 1. You've commented the IPF functionality: +#if ${PORT_OPTIONS:MIPFW} +#CONFIGURE_ARGS+= --firewall=ipfw +#.endif Was this intentional or can it be removed? 2. Same with AUTODETECT_FW. The option is defined but it does not seem to have a handler. 3. Your patch indroduced a lot of unneccessary whitespaces. Try running portlint -A (ports-mgmt/portlint) within the ports directory to catch those errors. 4. Also, the OPTIONS handling can be simplified with OPTIONS helpers. See: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html 5. I've created a patch to address most of the issues. Could you please apply it and look into 1 and 2? Additionally I've run portfmt and portclippy (ports-mgmt/portfmt) to address some indentation and formating issues.
Created attachment 215469 [details] Revised patch (see my comment)
(In reply to Tor Halvard Furulund from comment #0) Please check and approve the patch in https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215469 , thanks!
^Triage: Reset to Open, cannot be in progress without a (real) assignee)
Comment on attachment 215469 [details] Revised patch (see my comment) ^Triage: Request maintainer approval on attachments using the maintainer-approval attachment flag
2.2 is released as of 31/10/2020
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=cf362d342ecd7f14d40cec250dd25df3e94e5c66 commit cf362d342ecd7f14d40cec250dd25df3e94e5c66 Author: Emanuel Haupt <ehaupt@FreeBSD.org> AuthorDate: 2021-06-15 16:17:15 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-06-15 16:17:15 +0000 net/miniupnpd: Update to 2.1.20200510 From Tor Halvard Furulund: * Update to latest upstream. * Remove the extra patches as they are incorporated upstream From Emanuel Haupt: * Port cleanups PR: 246925 Reported by: Tor Halvard Furulund <squat@squat.no> Approved by: maintainer timeout, maintainer (previous version) net/miniupnpd/Makefile | 56 ++++++++++++---------- net/miniupnpd/distinfo | 6 +-- .../files/enable_check_portinuse.patch (gone) | 11 ----- net/miniupnpd/files/enable_igdv2.patch (gone) | 11 ----- net/miniupnpd/files/enable_ipv6.patch (gone) | 11 ----- net/miniupnpd/files/enable_leasefile.patch (gone) | 11 ----- .../files/enable_upnp_strict.patch (gone) | 11 ----- net/miniupnpd/files/extra-patch-portinuse.c (gone) | 49 ------------------- .../files/{patch-Makefile => patch-Makefile.bsd} | 12 ++--- .../files/pf_enable_filter_rules.patch (gone) | 11 ----- 10 files changed, 39 insertions(+), 150 deletions(-)
Thanks for your contributions!
(In reply to Daniel Engberg from comment #7) If you are inclined submit a new PR with the latest release.