Bug 247203 - www/librespeed: Improve pkg-message
Summary: www/librespeed: Improve pkg-message
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2020-06-12 12:31 UTC by Dries Michiels
Modified: 2020-06-16 02:23 UTC (History)
2 users (show)

See Also:


Attachments
librespeed.diff (2.75 KB, patch)
2020-06-12 12:31 UTC, Dries Michiels
driesm: maintainer-approval+
Details | Diff
librespeed.diff (2.75 KB, patch)
2020-06-12 12:34 UTC, Dries Michiels
driesm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dries Michiels freebsd_committer freebsd_triage 2020-06-12 12:31:44 UTC
Created attachment 215485 [details]
librespeed.diff

No functional change to the port, and should not require a revision bump. 
Simply improving the pkg-message, also including a pkg-remove message.
Comment 1 Dries Michiels freebsd_committer freebsd_triage 2020-06-12 12:34:38 UTC
Created attachment 215486 [details]
librespeed.diff

Also fix typo, prefered/s/preferred.
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2020-06-15 07:18:42 UTC
Hi, your patch includes the diff to files/pkg-message.in however the current ports tree doesn't have files directory.
https://svnweb.freebsd.org/ports/head/www/librespeed/

Submut a diff to current ports tree.
Comment 3 Dries Michiels freebsd_committer freebsd_triage 2020-06-15 10:07:17 UTC
Hi, I did a "svn move pkg-message files/pkg-message.in".
The patch doesn't apply cleanly with "svn patch mydiff"?

I'll attach a better diff for you to apply.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2020-06-15 15:35:57 UTC
Hmm, that's the correct procedure to create a patch. I'll give it a try again.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-06-16 01:52:08 UTC
A commit references this bug:

Author: meta
Date: Tue Jun 16 01:51:42 UTC 2020
New revision: 539310
URL: https://svnweb.freebsd.org/changeset/ports/539310

Log:
  www/librespeed: Improve pkg-message

  PR:		247203
  Submitted by:	Dries Michiels <driesm.michiels@gmail.com> (maintainer)

Changes:
  head/www/librespeed/Makefile
  head/www/librespeed/files/
  head/www/librespeed/files/pkg-message.in
  head/www/librespeed/pkg-message
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2020-06-16 02:23:48 UTC
Hand-applied the patch.

Committed, thanks!