Bug 247364 - www/pecl-solr does not build with php 7.4
Summary: www/pecl-solr does not build with php 7.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-17 23:55 UTC by hagabard
Modified: 2020-08-20 09:33 UTC (History)
2 users (show)

See Also:
gaod: maintainer-feedback+

Attachments
solr_types.h patch for port (263 bytes, text/plain)
2020-06-17 23:55 UTC, hagabard 		no flags Details
php74-pecl-solr-2.5.0.log from poudriere (65.23 KB, text/plain)
2020-06-17 23:59 UTC, hagabard 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description hagabard 2020-06-17 23:55:55 UTC 
Created attachment 215681 [details]
solr_types.h patch for port

There is no ulong typedef.

I submitted a bug @ php.net as well

https://bugs.php.net/bug.php?id=79708

To make this work, the patch can be dropped in the files/ directory.  I had to edit the Makefile because it is set to ignore PHP 7.4, and I also had to add configure arguments to have poudriere build it:  

CONFIGURE_ARGS= LIBXML_CFLAGS=-I/usr/local/include/libxml2 LIBXML_LIBS=-L/usr/local/include/libxml2
Comment 1 hagabard 2020-06-17 23:59:14 UTC 
Created attachment 215682 [details]
php74-pecl-solr-2.5.0.log from poudriere
Comment 2 Li-Wen Hsu freebsd_committer freebsd_triage 2020-06-18 06:42:43 UTC 
Reopen, accidentally closed this one.
Comment 3 Hung-Yi Chen 2020-07-11 17:25:48 UTC 
I'm fine with it, please commit it. Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-08-20 09:31:59 UTC 
A commit references this bug:

Author: lwhsu
Date: Thu Aug 20 09:31:36 UTC 2020
New revision: 545512
URL: https://svnweb.freebsd.org/changeset/ports/545512

Log:
  www/pecl-solr: Fix build for php 7.4

  PR:		247364
  Submitted by:	hagabard@gmail.com
  Approved by:	Hung-Yi Chen <gaod@hychen.org> (maintainer)
  MFH:		2020Q3 (blanket: build fix)

Changes:
  head/www/pecl-solr/Makefile
  head/www/pecl-solr/files/patch-src_php7_solr__types.h
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-08-20 09:33:02 UTC 
A commit references this bug:

Author: lwhsu
Date: Thu Aug 20 09:32:55 UTC 2020
New revision: 545513
URL: https://svnweb.freebsd.org/changeset/ports/545513

Log:
  MFH: r545512

  www/pecl-solr: Fix build for php 7.4

  PR:		247364
  Submitted by:	hagabard@gmail.com
  Approved by:	Hung-Yi Chen <gaod@hychen.org> (maintainer)

  Approved by:	portmgr (blanket: build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/www/pecl-solr/Makefile
  branches/2020Q3/www/pecl-solr/files/patch-src_php7_solr__types.h