Bug 247741 - overlay doesn't work with flavor
Summary: overlay doesn't work with flavor
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-03 14:37 UTC by Mikael Urankar
Modified: 2020-07-06 11:11 UTC (History)
1 user (show)

See Also:

Attachments
patch (532 bytes, patch)
2020-07-03 14:37 UTC, Mikael Urankar 		no flags Details | Diff
v2 (748 bytes, patch)
2020-07-03 16:25 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2020-07-03 14:37:59 UTC 
Created attachment 216173 [details]
patch

I'm playing with overlay and noticed the following problem: my port depends on a python port (both are parts of the overlay) but the pkg infra cannot find this dependency:

===>   py27-wapt-1.3.12.16 depends on package: py27-wakeonlan>=0.2 - not found
Error a dependency refers to a non existing origin: /usr/ports/net/py-wakeonlan in RUN_DEPENDS

find /overlays
...
/overlays/wapt/net/py-wakeonlan/Makefile
...
/overlays/wapt/sysutils/py-wapt/Makefile

the attached patch fixed the issue but I'm not sure it's correct.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2020-07-03 14:38:47 UTC 
btw, is there a way to overlay the UID / GID files?
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2020-07-03 16:03:02 UTC 
I think it would probably be better to move the flavor case/esac from after the overlay to before.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2020-07-03 16:25:47 UTC 
Created attachment 216176 [details]
v2

yes, you're right.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-07-06 11:11:06 UTC 
A commit references this bug:

Author: mat
Date: Mon Jul  6 11:10:16 UTC 2020
New revision: 541336
URL: https://svnweb.freebsd.org/changeset/ports/541336

Log:
  Fix overlays when using flavors.

  Move FLAVOR processing before the overlays processing so that flavors
  can be used with overlays.

  PR:		247741
  Submitted by:	mikael

Changes:
  head/Mk/Scripts/do-depends.sh