Created attachment 216385 [details] patch for games/dMagnetic from 0.23 to 0.24 Hello. My interpreter for Magnetic Scrolls games, dMagnetic, just received release number 0.24. I already patched the port. While I was at it, I changed the mechanism of the do-test target. Before, it was a target in the ports-Makefile. Now I made it a target within the release-Makefile. Could I bother you guys to have a look and tell me it this works for you? Thomas
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/165568426
Comment on attachment 216385 [details] patch for games/dMagnetic from 0.23 to 0.24 ^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval Attachment -> Details -> maintainer-approval [+]
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first
(In reply to Thomas Dettbarn from comment #0) The test target works fine so far but it can be further optimized. You can set > TEST_TARGET= do-test > TEST_ENV= ${MAKE_ENV} SHA256_CMD=sha256 and remove the "do-test" target in the port's Makefile completely. As far I can see there's also no need to set the SHA256_CMD variable as it's already set in the Makefile of the tarball if I'm not mistaken.
Created attachment 216465 [details] dMagnetic-0.24-revised.patch Here's a slightly revised patch based on your initial patch and the optimizations as noted in comment #4. Running "make test" should work as expected. The patch also changes the manpages path from man/ to share/man which is the preferred location since ports r523104.
Thank you. I will apply it into my personal repository as well. I just realized that the TIMESTAMP is still not a valid one, and I would like to apologize. May I bother you to re-generate the checksums and the timestamp as well? The .tar.bz2 has not changed on the server, so the checksum should not change.
Created attachment 216470 [details] dMagnetic-0.24-revised-v2.patch (In reply to Thomas Dettbarn from comment #6) No problem, here's the same version with a recent and more reasonable timestamp, thank you for the pointer!
Comment on attachment 216385 [details] patch for games/dMagnetic from 0.23 to 0.24 ^ Triage: Clean-up by setting the initial patch as obsolete because there's a revised version that will be used.
Comment on attachment 216470 [details] dMagnetic-0.24-revised-v2.patch ^ Triage: Set maintainer-approval to '+' on the revised patch that also contains a more recent timestamp as pointed out in comment #6.
^ Triage: Feedback was also given by comment #6, setting the maintainer-feedback flag accordingly.
A commit references this bug: Author: kai Date: Fri Jul 17 06:32:32 UTC 2020 New revision: 542409 URL: https://svnweb.freebsd.org/changeset/ports/542409 Log: games/dMagnetic: Update to 0.24 * Simplify test suite. [1] * Switch manpages to the preferred share/man location while I'm here. Changelog: * It is now possible to use .d64 images to play the games. * The test suite can now be called directly via its own "do-test" target per sub-make. [1] PR: 247915 Submitted by: Thomas Dettbarn <dettus@dettus.net> (maintainer) Changes: head/games/dMagnetic/Makefile head/games/dMagnetic/distinfo head/games/dMagnetic/pkg-plist
Committed, thank you for the patch and your feedback!