**Describe the bug** The `acme.sh` client installed on OPNsense doesn't contain all the DNS plugin scripts. **To Reproduce** Steps to reproduce the behaviour: 1. Download https://github.com/acmesh-official/acme.sh/archive/2.8.6.tar.gz 2. Check its SHA2 sum with the value from [opnsense/ports/distinfo](https://github.com/opnsense/ports/blob/master/security/acme.sh/distinfo) 3. Extract the tar.gz and see all dnsapi plugins contained in the `2.8.6.` release. ``` $ ls Downloads/acme.sh-2.8.6/dnsapi | wc -l 105 ``` 4. ssh into opnsense and run ``` $ sudo ls /var/db/acme/.acme.sh/dnsapi | wc -l 95 ``` 5. Comparing `/var/db/acme/.acme.sh/dnsapi` with the release tar reveals the 10 missing plugin scripts: ``` $ diff Downloads/acme.sh-2.8.6/dnsapi opn_dnsapi Only in Downloads/acme.sh-2.8.6/dnsapi: dns_1984hosting.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_arvan.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_clouddns.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_constellix.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_df.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_dynv6.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_joker.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_kas.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_nm.sh Only in Downloads/acme.sh-2.8.6/dnsapi: dns_opnsense.sh ``` **Expected behavior** The folder `/var/db/acme/.acme.sh/dnsapi` should have the same contents as the `dnsapi` folder from the release tar, as its SHA2 sum and file size match. ``` $ shasum -a 256 Downloads/acme.sh-2.8.6.tar.gz fd36cb749466296ded521ceacda3fc841ec76be620900d1116e0492d171c1d9f Downloads/acme.sh-2.8.6.tar.gz ------------------------------------------------------------ $ ls -al Downloads/acme.sh-2.8.6.tar.gz -rw-r--r--@ 1 test nobody 193182 Aug 1 15:37 Downloads/acme.sh-2.8.6.tar.gz ```` **Environment** OPNsense 20.7-amd64 FreeBSD 12.1-RELEASE-p7-HBSD OpenSSL 1.1.1g 21 Apr 2020
Created attachment 216953 [details] fix pkg-plist of security/acme.sh Attached patch will fix pkg-plist to include all dnsapi files provided by acme.sh.
I can duplicate that here.
A commit references this bug: Author: dvl Date: Sun Aug 2 12:40:00 UTC 2020 New revision: 543948 URL: https://svnweb.freebsd.org/changeset/ports/543948 Log: Include missing plugin scripts Thanks to Frank Wall <fw@moov.de> for the patch. PR: 248425 Submitted by: phedoreanu <phedoreanu@wearehackerone.com> MFH: 2020Q3 Changes: head/security/acme.sh/Makefile head/security/acme.sh/pkg-plist
I will leave this PR open until I hear back from ports-secteam regarding my MFH 2020
(In reply to Dan Langille from comment #4) * 2020Q3 MFH request.
A commit references this bug: Author: dvl Date: Sun Aug 2 14:02:14 UTC 2020 New revision: 543962 URL: https://svnweb.freebsd.org/changeset/ports/543962 Log: MFH: r543948 Include missing plugin scripts Thanks to Frank Wall <fw@moov.de> for the patch. PR: 248425 Submitted by: phedoreanu <phedoreanu@wearehackerone.com> Approved by: ports-secteam (joneum) Changes: _U branches/2020Q3/ branches/2020Q3/security/acme.sh/Makefile branches/2020Q3/security/acme.sh/pkg-plist
Thank you.