Bug 248635 - lang/spidermonkey68: Fix build on GCC architectures
Summary: lang/spidermonkey68: Fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias C. Berner
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-08-12 22:19 UTC by Piotr Kubaj
Modified: 2020-08-13 09:04 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+
koobs: merge-quarterly?

Attachments
patch (1.29 KB, patch)
2020-08-12 22:19 UTC, Piotr Kubaj 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-08-12 22:19:48 UTC 
Created attachment 217181 [details]
patch

Don't unconditionally use clang, it breaks build where clang is not available.

configure: error: compiler is incompatible with sanitize options
DEBUG: <truncated - see config.log for full output>
DEBUG: ld: error: /usr/src/lib/csu/powerpc64/crt1.c:96:(.text+0xDE): relocation R_PPC64_TOC16_DS out of range: -32848 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/powerpc64/crt1.c:96:(.text+0x10A): relocation R_PPC64_TOC16_DS out of range: -32840 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/powerpc64/crt1.c:88:(.text+0x12E): relocation R_PPC64_TOC16_DS out of range: -32904 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:114:(.text+0x14E): relocation R_PPC64_TOC16_DS out of range: -32912 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:114:(.text+0x152): relocation R_PPC64_TOC16_DS out of range: -32896 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:116:(.text+0x16E): relocation R_PPC64_TOC16_DS out of range: -32888 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:116:(.text+0x172): relocation R_PPC64_TOC16_DS out of range: -32880 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:122:(.text+0x1D2): relocation R_PPC64_TOC16_DS out of range: -32872 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:123:(.text+0x1F2): relocation R_PPC64_TOC16_DS out of range: -32864 is not in [-32768, 32767]
DEBUG: ld: error: /usr/src/lib/csu/common/ignore_init.c:123:(.text+0x1F6): relocation R_PPC64_TOC16_DS out of range: -32856 is not in [-32768, 32767]
DEBUG: ld: error: too many errors emitted, stopping now (use -error-limit=0 to see all errors)
DEBUG: clang-9: error: linker command failed with exit code 1 (use -v to see invocation)

Instead, use GCC from ports there.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-13 04:29:15 UTC 
Comment on attachment 217181 [details]
patch

^Triage: Fetch, configure, build, run, package fixes are:

Approved by: portmgr (blanket: <type> fix)
MFH: <branch> (blanket: <type> fix)
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2020-08-13 06:25:09 UTC 
Lgtm

Thanks
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-08-13 09:04:20 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Aug 13 09:03:52 UTC 2020
New revision: 544791
URL: https://svnweb.freebsd.org/changeset/ports/544791

Log:
  lang/spidermonkey68: fix build on GCC architectures

  Use Clang only on clang architectures.

  PR:		248635
  Approved by:	tcberner (maintainer)

Changes:
  head/lang/spidermonkey68/Makefile