Bug 248717 - www/browsh: drop arm64 from ONLY_FOR_ARCHS
Summary: www/browsh: drop arm64 from ONLY_FOR_ARCHS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-08-18 06:50 UTC by Jan Beich
Modified: 2020-08-18 07:31 UTC (History)
0 users

See Also:
0mp: maintainer-feedback+

Attachments
fix (764 bytes, patch)
2020-08-18 06:50 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2020-08-18 06:50:40 UTC 
Created attachment 217296 [details]
fix

ONLY_FOR_ARCHS uses ARCH aka "uname -p" aka MACHINE_ARCH (BSD make) or hw.machine_arch (sysctl). _ALL_DISTFILES defines only 4 files, and upstream doesn't provide *_freebsd_arm64 binaries.

$ make targets -C/usr/src | fgrep arm64
    arm64/aarch64
Comment 1 Jan Beich freebsd_committer freebsd_triage 2020-08-18 07:03:23 UTC 
http://thunderx1.nyi.freebsd.org/data/latest-per-pkg/browsh/ if exists should have arm64/aarch64 build logs. When an architecture is not in ONLY_FOR_ARCHS there is supposed to be a very short build log about skipped build.

At the moment both thunderx1 and ref*-aarch64 machines appear to be down, so I can't check myself.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-08-18 07:27:49 UTC 
A commit references this bug:

Author: 0mp
Date: Tue Aug 18 07:27:38 UTC 2020
New revision: 545220
URL: https://svnweb.freebsd.org/changeset/ports/545220

Log:
  Clean up ONLY_FOR_ARCHS

  Upstream does not build packages for FreeBSD arm64.

  PR:		248717
  Submitted by:	jbeich

Changes:
  head/www/browsh/Makefile
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-08-18 07:28:14 UTC 
Right! Thanks for your report!
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-08-18 07:31:19 UTC 
I've submitted a PR upstream to update the website: https://github.com/browsh-org/www.brow.sh/pull/29