Bug 248855 - lang/halide: Builds with with -march=native even when you tell it not to
Summary: lang/halide: Builds with with -march=native even when you tell it not to
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2020-08-23 18:28 UTC by Mark Linimon
Modified: 2020-09-07 02:28 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)
koobs: merge-quarterly?

Attachments
excerpt from aarch64 errorlog (1.11 KB, text/plain)
2020-08-23 18:28 UTC, Mark Linimon 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2020-08-23 18:28:07 UTC 
Created attachment 217460 [details]
excerpt from aarch64 errorlog

See the attached errorlog halide-2019.08.27.2023_1.log from a recent aarch64 -head run.

The following confusing code is in test/CMakeLists.txt:

  set(ARCH_FOR_TESTS "$ENV{ARCH_FOR_TESTS}")
  if ("${ARCH_FOR_TESTS}" STREQUAL "")
    set(ARCH_FOR_TESTS "native")
  endif()

and I can't figure out what they are trying to accomplish here (or I'd try to fix it).
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-08-25 21:25:01 UTC 
A commit references this bug:

Author: yuri
Date: Tue Aug 25 21:24:57 UTC 2020
New revision: 546232
URL: https://svnweb.freebsd.org/changeset/ports/546232

Log:
  lang/halide: Remove tests from build

  PR:		248855

Changes:
  head/lang/halide/Makefile
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2020-08-25 21:26:19 UTC 
(In reply to Mark Linimon from comment #0)


Hi Mark,

I removed tests from build. This should prevent the code that caused trouble from being executed.

Could you please retest?

Thanks,
Yuri
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2020-09-06 22:39:08 UTC 
Mark,


Please reopen if this is still a problem.


Yuri
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2020-09-07 02:28:32 UTC 
(In reply to Yuri Victorovich from comment #3)

This particular problem is now fixed.  It unblocked a different failure but that is not relevant for this PR.