Created attachment 217595 [details] update to 1.8.0 Update Kea to latest stable 1.8.0
build failed : ... ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/code_of_conduct.md Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/platforms.rst ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1
Wen, those files are not getting installed to the /usr/local, I'm not sure why they getting flagged?
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval. -- Attachment -> Details -> maintainer-approval [+] Thanks!
A commit references this bug: Author: dbaio Date: Sat Sep 12 23:18:25 UTC 2020 New revision: 548437 URL: https://svnweb.freebsd.org/changeset/ports/548437 Log: net/kea: Update to 1.8.0 DISTNAME is ${PORTNAME}-${PORTVERSION} by default -- portlint PR: 248973 Submitted by: Andrey Pevnev <apevnev@me.com> (maintainer) Changes: head/net/kea/Makefile head/net/kea/distinfo head/net/kea/files/patch-src_bin_keactrl_keactrl.in head/net/kea/pkg-plist
A commit references this bug: Author: dbaio Date: Sat Sep 12 23:29:57 UTC 2020 New revision: 548438 URL: https://svnweb.freebsd.org/changeset/ports/548438 Log: net/kea: Add back DISTNAME I shouldn't have removed the DISTNAME variable in ports r548437, it will be necessary in a future -P1 release. PR: 248973 Changes: head/net/kea/Makefile
I've fixed the plist, and the update is committed, thanks!
The patch to support colors when issuing a `service kea status` was deleted by accident. This completely breaks colorization once the command has been issued. Could you please add it back?
(In reply to Jose Luis Duran from comment #7) Hum, thanks for reporting it. I thought that was not necessary anymore. apevnev@me.com, is this fine for you?
Let me take a look, I though it was not needed either as that change is now in the upstream.
(In reply to Andrey Pevnev from comment #9) I see. The bug is upstream. They only changed the "opening" sequence, and forgot the "closing" one: active="\033[92mactive\e[0m" It should have been: active="\033[92mactive\033[0m" For both, "active" and "incative". I am a little busy at the moment to submit a patch upstream, would you mind doing it? Thank you!
Created attachment 218085 [details] update to 1.8.0_1 There is an updated patch, also removes nojail keyword to address 237909. Thanks!
(In reply to Jose Luis Duran from comment #10) Added a comment on the upstream PR: https://gitlab.isc.org/isc-projects/kea/-/merge_requests/757
A commit references this bug: Author: dbaio Date: Sat Sep 19 20:18:46 UTC 2020 New revision: 549059 URL: https://svnweb.freebsd.org/changeset/ports/549059 Log: net/kea: Fix colorized output for `keactl status` It wasn't properly fixed in the upstream. PR: 248973 Submitted by: Andrey Pevnev <apevnev@me.com> (maintainer) Reported by: Jose Luis Duran <jlduran@gmail.com> Event: September 2020 Bugathon Changes: head/net/kea/Makefile head/net/kea/files/patch-src_bin_keactrl_keactrl.in
Committed. I didn't touch the rc script, I'll ask for you to make a final patch and add to bug 237909. Any issues, please let me know.
Thank you sir! Added patch to that bug: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=218091&action=diff