Bug 249103 - devel/cargo-generate: Remove openssl-src cargo crate
Summary: devel/cargo-generate: Remove openssl-src cargo crate
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitri Goutnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-04 12:59 UTC by Lewis Cook
Modified: 2020-09-04 18:32 UTC (History)
1 user (show)

See Also:

Attachments
cargo-generate-0.5.0.diff (1.62 KB, patch)
2020-09-04 12:59 UTC, Lewis Cook 		lcook: maintainer-approval+
Details | Diff
cargo-generate-0.5.0_1.diff (3.00 KB, patch)
2020-09-04 17:15 UTC, Lewis Cook 		lcook: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-09-04 12:59:22 UTC 
Created attachment 217740 [details]
cargo-generate-0.5.0.diff

* Whilst here, pet portclippy.
* Address check-sanity stage message by removing
  vendored copy of OpenSSL [1].

[1] Please make sure this port uses the system OpenSSL and consider removing
CARGO_CRATES=openssl-src-111.6.0+1.1.1d (a vendored copy of OpenSSL) from the
build, e.g., by patching Cargo.toml appropriately. 

QA:

 * portlint: OK (looks fine).
 * testport: OK (poudriere: 12.1-RELEASE-p8, amd64).

MFH: No (Port not in 2020Q3).
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2020-09-04 16:00:37 UTC 
Does this update also need a PORTREVISION bump?
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2020-09-04 16:48:50 UTC 
Negative. The port was only just committed to HEAD yesterday therefore not in the 2020Q3 branch.
Comment 3 Dmitri Goutnik freebsd_committer freebsd_triage 2020-09-04 16:57:28 UTC 
(In reply to Lewis Cook from comment #2)
Sorry, I mean does this update change the generated package or binary in any way? If it does, then port's PORTREVISION needs to be increased [1].

[1] https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-portrevision
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2020-09-04 17:15:01 UTC 
Created attachment 217752 [details]
cargo-generate-0.5.0_1.diff
Comment 5 Lewis Cook freebsd_committer freebsd_triage 2020-09-04 17:15:16 UTC 
(In reply to Dmitri Goutnik from comment #3)
(In reply to Dmitri Goutnik from comment #3)
Since the port was only committed yesterday (thus not in 2020Q3, but in HEAD) it didn't occur to me to bump PORTREVISION. My assumption is that users compiling from HEAD will need a PORTREVISION bump just to be safe?

Looking back at the patch and it seems I didn't `make makesum` to re-generate distinfo. I've attached a patch addressing that and what you've said (as the package contents `distinfo` changes).

Thanks for catching that. :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2020-09-04 18:28:43 UTC 
A commit references this bug:

Author: dmgk
Date: Fri Sep  4 18:28:08 UTC 2020
New revision: 547561
URL: https://svnweb.freebsd.org/changeset/ports/547561

Log:
  devel/cargo-generate: Remove openssl-src cargo crate

  - Address check-sanity stage message by removing vendored copy of OpenSSL.
  - Whilst here, pet portclippy.

  PR:		249103
  Submitted by:	Lewis Cook <vulcan@wired.sh> (maintainer)

Changes:
  head/devel/cargo-generate/Makefile
  head/devel/cargo-generate/distinfo
  head/devel/cargo-generate/files/
  head/devel/cargo-generate/files/patch-Cargo.toml
Comment 7 Dmitri Goutnik freebsd_committer freebsd_triage 2020-09-04 18:32:23 UTC 
Committed, thanks!