Bug 249459 - [patch] cad/calculix update to 2.17.1
Summary: [patch] cad/calculix update to 2.17.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pedro F. Giffuni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-19 18:56 UTC by rsmith
Modified: 2020-09-22 17:33 UTC (History)
0 users

See Also:
pfg: maintainer-feedback-

Attachments
Patch to update the port to 2.17.1. (4.05 KB, patch)
2020-09-19 18:56 UTC, rsmith 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2020-09-19 18:56:06 UTC 
Created attachment 218086 [details]
Patch to update the port to 2.17.1.

Apart from new colormaps, this 2.17.1 contains a fix for a pretty serious bug. In 2.17, when exporting a surface ("send XXX abq sur"), the *SURFACE keyword is missing from the generated XXX.sur file. Since surfaces are necessary for applying distributed loads, this cripples cgx for problems with distributed loads.

I have run the usual tests from the porters handbook and found no issues.
Portlint only gives a couple of warnings:
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
0 fatal errors and 2 warnings found.
Comment 1 Pedro F. Giffuni freebsd_committer freebsd_triage 2020-09-19 19:32:50 UTC 
I am currently very busy with someone from my family in the hospital, so it may take a while for me to get this. If some other committers wants to go ahead, I approve.
Comment 2 Pedro F. Giffuni freebsd_committer freebsd_triage 2020-09-22 17:23:08 UTC 
Patch is insufficient. Still have to modify the path for other patches:
===>  License GPLv2 accepted by the user
===>   calculix-2.17.1 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by calculix-2.17.1 for building
===>  Extracting for calculix-2.17.1
=> SHA256 Checksum OK for calculix/cgx_2.17.1.all.tar.bz2.
=> SHA256 Checksum OK for calculix/cgx_2.17.1.exa.tar.bz2.
=> SHA256 Checksum OK for calculix/cgx_2.17.1.htm.tar.bz2.
=> SHA256 Checksum OK for calculix/cgx_2.17.1.pdf.
===>  Patching for calculix-2.17.1
===>  Applying FreeBSD patches for calculix-2.17.1 from /usr/ports/cad/calculix/files
File to patch: ^C===>  FAILED Applying FreeBSD patch-cgx__VER_src_Makefile
===> FAILED to apply cleanly FreeBSD patch(es)  patch-cgx__VER_src_Makefile
*** Error code 1
*** Signal 2
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-09-22 17:32:52 UTC 
A commit references this bug:

Author: pfg
Date: Tue Sep 22 17:32:09 UTC 2020
New revision: 549614
URL: https://svnweb.freebsd.org/changeset/ports/549614

Log:
  cad/calculix : update to version 2.17.1

  PR:	249459
  Approved by:	thierry (mentor, implicit)

Changes:
  head/cad/calculix/Makefile
  head/cad/calculix/distinfo
  head/cad/calculix/files/patch-cgx__2.17_src_pickFunktions.c
  head/cad/calculix/files/patch-cgx__VER_src_Makefile
  head/cad/calculix/pkg-plist
Comment 4 Pedro F. Giffuni freebsd_committer freebsd_triage 2020-09-22 17:33:37 UTC 
Committed, thanks!