Bug 250087 - graphics/drawpile: Fix compilation with libmicrohttpd 0.9.71
Summary: graphics/drawpile: Fix compilation with libmicrohttpd 0.9.71
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 249453
  Show dependency tree / graph
 
Reported: 2020-10-04 05:09 UTC by Daniel Engberg
Modified: 2020-10-04 06:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Patch for drawpile (3.05 KB, patch)
2020-10-04 05:09 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2020-10-04 05:09:46 UTC 
Created attachment 218504 [details]
Patch for drawpile

Add upstream patches to fix compilation with libmicrohttpd 0.9.71
Use release archive as suggested by section 5.4.3 in Porter's Handbook.
Remove local patch files to add QPainterPath header and use PATCH_SITES instead.

Compile tested on FreeBSD 13.0-CURRENT #0 r364979 (amd64) (make + make check-plist )
Poudriere testport OK 12.1-RELEASE (amd64)
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2020-10-04 06:24:14 UTC 
Committed except for change to MASTER_SITES.

In case the next release would be broken GH_* tags would still need to be added, and this happens a lot in general, so I would prefer to keep GH_* tags as more robust.

Thank you for the patch!
Yuri
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-10-04 06:24:37 UTC 
A commit references this bug:

Author: yuri
Date: Sun Oct  4 06:24:10 UTC 2020
New revision: 551356
URL: https://svnweb.freebsd.org/changeset/ports/551356

Log:
  graphics/drawpile: Backport patch fixing compilation with libmicrohttpd 0.9.71; Backport patches fixing missing #include <QPainterPath>

  PR:		250087
  Submitted by:	daniel.engberg.lists@pyret.net

Changes:
  head/graphics/drawpile/Makefile
  head/graphics/drawpile/distinfo
  head/graphics/drawpile/files/patch-src_desktop_bundled_QtColorWidgets_color__wheel.cpp
  head/graphics/drawpile/files/patch-src_desktop_widgets_popupmessage.h