Bug 250227 - sysutils/mtm: use base ncurses where possible
Summary: sysutils/mtm: use base ncurses where possible
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-09 15:57 UTC by Steve Wills
Modified: 2020-10-14 10:51 UTC (History)
0 users

See Also:
0mp: maintainer-feedback+

Attachments
patch to port (486 bytes, patch)
2020-10-09 15:57 UTC, Steve Wills 		no flags Details | Diff
updated patch (678 bytes, patch)
2020-10-12 13:14 UTC, Steve Wills 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2020-10-09 15:57:21 UTC 
Created attachment 218626 [details]
patch to port

Base ncurses is new enough for this port to use in 13.x and later, let's use it there.
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-10-09 16:02:17 UTC 
Sure, I can commit it soon.

BTW, shouldn't we include bsd.port.pre.mk before using OPSYS like this?
Comment 2 Steve Wills freebsd_committer freebsd_triage 2020-10-09 16:49:47 UTC 
(In reply to Mateusz Piotrowski from comment #1)
Probably, and actually that patch is wrong. And this seems like it should be right:

https://reviews.freebsd.org/P435

but doesn't work. I'll dig into it some more.
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-10-09 17:10:12 UTC 
(In reply to Steve Wills from comment #2)
Alright, please let me know if you find something interesting.
Comment 4 Steve Wills freebsd_committer freebsd_triage 2020-10-12 13:14:41 UTC 
Created attachment 218692 [details]
updated patch

This should do it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-10-14 10:51:18 UTC 
A commit references this bug:

Author: 0mp
Date: Wed Oct 14 10:51:13 UTC 2020
New revision: 552324
URL: https://svnweb.freebsd.org/changeset/ports/552324

Log:
  Let mtm use ncurses from the base system on recent CURRENT

  Also, update manual page installation path.

  PR:		250227
  Submitted by:	swills

Changes:
  head/sysutils/mtm/Makefile
Comment 6 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-10-14 10:51:28 UTC 
Thanks!