Bug 250776 - textproc/fzf: Update to 0.24.1
Summary: textproc/fzf: Update to 0.24.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-01 14:20 UTC by Ashish SHUKLA
Modified: 2020-11-08 07:15 UTC (History)
1 user (show)

See Also:
sascha: maintainer-feedback+


Attachments
Update to 0.24.1 (5.40 KB, patch)
2020-11-01 14:20 UTC, Ashish SHUKLA
no flags Details | Diff
Update to 0.24.2 (5.49 KB, patch)
2020-11-07 18:07 UTC, Ashish SHUKLA
ashish: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ashish SHUKLA freebsd_committer freebsd_triage 2020-11-01 14:20:13 UTC
Created attachment 219275 [details]
Update to 0.24.1
Comment 1 Sascha Holzleiter 2020-11-01 23:34:12 UTC
Looks fine to me, but please also update the revision in GO_BUILDFLAGS.
Thanks for the update!
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2020-11-07 18:07:13 UTC
Created attachment 219433 [details]
Update to 0.24.2

Sorry for the delay in follow up.

Apparently new release is out, could you please review the attached diff ?

Thanks!
Comment 3 Sascha Holzleiter 2020-11-08 02:33:51 UTC
Comment on attachment 219433 [details]
Update to 0.24.2

Looks good and also works for me, thanks again for the patch!
Comment 4 Sascha Holzleiter 2020-11-08 02:37:11 UTC
For whatever reason i cannot seem to change the  maintainer-approval flag on the new attachment, so consider it approved ;)
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-11-08 07:09:26 UTC
A commit references this bug:

Author: ashish
Date: Sun Nov  8 07:09:08 UTC 2020
New revision: 554436
URL: https://svnweb.freebsd.org/changeset/ports/554436

Log:
  - Update to 0.24.2

  PR:		250776
  Approved by:	Sascha Holzleiter <sascha at root-login dot org>(maintainer)

Changes:
  head/textproc/fzf/Makefile
  head/textproc/fzf/distinfo
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2020-11-08 07:15:29 UTC
Committed, thanks!