Created attachment 219358 [details] Cava 0.7.3 update The attach patch updates audio/cava to 0.7.3 as well as updates maintainer to me. Portlist: OK (Looks good) Poudriere testport: 12.1-RELEASE, 12.2-RELEASE <amd64, i386> OK
I don't know if it is needed or not, but since 0.7.2 was skipped here is the upstream changelog for that version as well https://github.com/karlstav/cava/releases/tag/0.7.2
Hi Adam, Thanks for your patch and thanks for taking maintainership. Because I am a new, mentored committer, I opened a review on Phabricator[1]. One of my mentors asked about the usefullness of the last hunk for Makefile.am, which seems to only remove two empty lines at the end of the file? If this is for style reasons, shouldn't we also remove one of the empty two lines before this hunk? Of course, we could also do without is well, because it is only at build time ... What do you think? [1] https://reviews.freebsd.org/D27091
(In reply to Rainer Hurling from comment #2) Hello Rainer, Thanks for taking a look at this so quickly, and for the feedback. If you are talking about lines 29 and 30 here https://bugs.freebsd.org/bugzilla/attachment.cgi?id=219358&action=diff#b/audio/cava/files/patch-Makefile.am_sec1 Those appear to be more accidental changes than intended. Looking at the upstream copy of Makefile.am (https://github.com/karlstav/cava/blob/0.7.3/Makefile.am#L54) there are two empty lines at the end of the file and I have VIM configured to strip cases like that. If desired I will gladly reroll my patch keeping those two empty lines intact. :)
(In reply to Adam Jimerson from comment #3) These lines should only be removed for stylistic reasons. FreeBSD ports usually patch sources to make them run or to add or change functionality, but this is not intended to improve the style of the source code. Therefore, the last hunk can be omitted. Please decide for yourself if the effort here is justified ;) I am fine with both, the existing patch or a new one.
Well since it was an unintended change, I'll submit a new patch after I tweak my Vim settings to not remove empty lines at EOF. I do agree that needless changes should not be made, and I should have caught that before submitting my patch.
(In reply to Adam Jimerson from comment #5) Hi Adam, Any chance to add the updated patch on Bugzilla in the next time? Please do not misunderstand me. I do not want to push ;)
Created attachment 219411 [details] Cava 0.7.3 V2 update This patch preserves the 2 empty lines at the end of Makefile.am.
A commit references this bug: Author: rhurlin Date: Fri Nov 13 12:19:42 UTC 2020 New revision: 555017 URL: https://svnweb.freebsd.org/changeset/ports/555017 Log: audio/cava: Update to 0.7.3 Update from 0.7.1 to 0.7.3 brings several improvements and bug fixes[1][2]. More important ones are: - Fix install on macos - ncurses mode is now default again - Improved portaudio audio input - Added Hann windowing and proper ring buffer [1] https://github.com/karlstav/cava/releases/tag/0.7.3 [2] https://github.com/karlstav/cava/releases/tag/0.7.2 PR: 250862 Submitted by: Adam Jimerson <vendion@gmail.com> (takes maintainership) Approved by: arrowd (mentor) Differential Revision: https://reviews.freebsd.org/D27091 Changes: head/audio/cava/Makefile head/audio/cava/distinfo head/audio/cava/files/patch-Makefile.am head/audio/cava/files/patch-cava.c head/audio/cava/files/patch-config.c head/audio/cava/files/patch-example__files_config head/audio/cava/files/patch-input_sndio.c head/audio/cava/files/patch-output_terminal__ncurses.c
Committed, thanks! Sorry for the delay, we were very busy :(