Created attachment 219367 [details] Update of devel/gindent o Patch buggy patch-src_args.c. It segfaults when used with -orig, -knf, -kr, or -gnu. The extension of the options struct in args.c by *_PRO_SETTINGS is broken. For p_obj a string of a group of options is given. However, in the PRO_SETTINGS case, set_option() expects an index for the settings_string array instead. Details: - Remove BSD_PRO_SETTINGS as its string matches exactly ORIG_SETTINGS_STRING. So the intended behavior of -orig is already available. - Remove KR_PRO_SETTINGS as it does not correspond to Kernighan-Ritchie style. The flags -sar and -par seem to be missing. Since they are included in KR_SETTINGS_STRING, use that string instead. - Remove GNU_PRO_SETTINGS as its string matches exactly GNU_SETTINGS_STRING; use it instead. - Remove KNF_PRO_SETTINGS and introduce KNF_SETTINGS_STRING and use it like the other settings strings. This makes a version bump necessary, we therefore set PORTREVISION=1. o Patch Makefile.in to make --htmldir work. Remove post-install target as it's not necessary anymore. o Change PORTVERSION to DISTVERSION (PHB Sect. 5.2.2). Modify DISTNAME accordingly. o Make COMMENT more meaningful. o Remove MAKE_JOBS_UNSAFE as tests suggest that it's not necessary (anymore). o Add groff:run to USES variable. This registers a dependency on textproc/groff. It's needed to render the manpage. o Added description for NLS option, which is slightly more verbose then the default description. This update is related to bug #250811, which may be closed.
Created attachment 219368 [details] Poudriere test logs
Build and package info is available at https://gitlab.com/swills/freebsd-ports/pipelines/212288421
Created attachment 219420 [details] Poudriere test log
Created attachment 219421 [details] Poudriere portlint log
A commit references this bug: Author: mikael Date: Sat Nov 7 16:02:43 UTC 2020 New revision: 554402 URL: https://svnweb.freebsd.org/changeset/ports/554402 Log: devel/gindent: update port Update of devel/gindent o Patch buggy patch-src_args.c. It segfaults when used with -orig, -knf, -kr, or -gnu. The extension of the options struct in args.c by *_PRO_SETTINGS is broken. For p_obj a string of a group of options is given. However, in the PRO_SETTINGS case, set_option() expects an index for the settings_string array instead. Details: - Remove BSD_PRO_SETTINGS as its string matches exactly ORIG_SETTINGS_STRING. So the intended behavior of -orig is already available. - Remove KR_PRO_SETTINGS as it does not correspond to Kernighan-Ritchie style. The flags -sar and -par seem to be missing. Since they are included in KR_SETTINGS_STRING, use that string instead. - Remove GNU_PRO_SETTINGS as its string matches exactly GNU_SETTINGS_STRING; use it instead. - Remove KNF_PRO_SETTINGS and introduce KNF_SETTINGS_STRING and use it like the other settings strings. This makes a version bump necessary, we therefore set PORTREVISION=1. o Patch Makefile.in to make --htmldir work. Remove post-install target as it's not necessary anymore. o Change PORTVERSION to DISTVERSION (PHB Sect. 5.2.2). Modify DISTNAME accordingly. o Make COMMENT more meaningful. o Remove MAKE_JOBS_UNSAFE as tests suggest that it's not necessary (anymore). o Add groff:run to USES variable. This registers a dependency on textproc/groff. It's needed to render the manpage. o Added description for NLS option, which is slightly more verbose then the default description. PR: 250876 Submitted by: Moritz Schmitt <moritz@schmi.tt> (maintainer) Changes: head/devel/gindent/Makefile head/devel/gindent/files/patch-doc_Makefile.in head/devel/gindent/files/patch-src_args.c
Thanks!