Bug 250878 - math/cddlib: requesting maintainership
Summary: math/cddlib: requesting maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 13:08 UTC by Moritz Schmitt
Modified: 2020-12-15 12:30 UTC (History)
2 users (show)

See Also:


Attachments
Update of math/cddlib (5.29 KB, text/plain)
2020-11-07 07:08 UTC, Moritz Schmitt
no flags Details
Poudriere test log (128.25 KB, text/plain)
2020-11-07 07:09 UTC, Moritz Schmitt
no flags Details
Poudriere portlint log (12 bytes, text/plain)
2020-11-07 07:10 UTC, Moritz Schmitt
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Moritz Schmitt 2020-11-05 13:08:24 UTC
math/cddlib currently doesn't have a maintainer. I'd like to take over maintainership for this port.
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2020-11-05 13:13:58 UTC
Thanks for being interested in this port.  We usually transfer maintainership along with an update.  How about attaching a patch to update it to 0.94l and put yourself in the MAINTAINER field?
Comment 2 Moritz Schmitt 2020-11-07 07:08:14 UTC
I think this is an excellent idea. Please find attached my port update. I not
only updated the port but also did a bit of a clean-up.

Here is what changed:

- Remove PORTREVISION as we upgrade the port to a new version.
- Update MAINTAINER.
- Simplify COMMENT.
- Remove USE_GITHUB and include MASTER_SITES instead. We are only working with
  releases anyway, and the release tar.gz includes already build documentation,
  which means we don't depend on TeX Live for building the manual anymore.
- Replace MANUAL with the more common DOCS option.
- Rewrite/add DOCS_DESC and EXAMPLES_DESC.
- Remove pre-build-MANUAL-off target as it is not necessary when using a
  release, including the documentation.
- Remove do-install target and non-standard variable HEADERSDIR. The header
  files are installed in ${PREFIX}/include/cddlib by default. Create a link to
  ${PREFIX}/include/cdd in post-install target. Some applications expect the
  headers to be in cdddlib others in cdd, so we should provide both
  directories.
- Remove post-install-MANUAL-on target as it is not necessary anymore.
- Merge post-install-EXAMPLES-on target with the post-install target.
- Rewrite pkg-descr.
- Update distinfo.
Comment 3 Moritz Schmitt 2020-11-07 07:08:58 UTC
Created attachment 219417 [details]
Update of math/cddlib
Comment 4 Moritz Schmitt 2020-11-07 07:09:55 UTC
Created attachment 219418 [details]
Poudriere test log
Comment 5 Moritz Schmitt 2020-11-07 07:10:50 UTC
Created attachment 219419 [details]
Poudriere portlint log
Comment 6 Moritz Schmitt 2020-11-25 13:13:50 UTC
Any news regarding my patch? Is anything missing?
Comment 7 Max Brazhnikov freebsd_committer freebsd_triage 2020-12-15 12:29:48 UTC
Committed, thank you!
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-12-15 12:30:10 UTC
A commit references this bug:

Author: makc
Date: Tue Dec 15 12:29:13 UTC 2020
New revision: 558158
URL: https://svnweb.freebsd.org/changeset/ports/558158

Log:
  math/cddlib:
  - Update to 0.94l
  - Adopt port
  - Simplify COMMENT.
  - Remove USE_GITHUB and include MASTER_SITES instead. We are only working with
    releases anyway, and the release tar.gz includes already build documentation,
    which means we don't depend on TeX Live for building the manual anymore.
  - Replace MANUAL with the more common DOCS option.
  - Remove do-install target and non-standard variable HEADERSDIR. The header
    files are installed in ${PREFIX}/include/cddlib by default. Create a link to
    ${PREFIX}/include/cdd in post-install target. Some applications expect the
    headers to be in cdddlib others in cdd, so we should provide both
    directories.
  - Rewrite pkg-descr.

  PR:		250878
  Submitted by:	Moritz Schmitt

Changes:
  head/math/cddlib/Makefile
  head/math/cddlib/distinfo
  head/math/cddlib/pkg-descr
  head/math/cddlib/pkg-plist