Bug 250886 - [patch] security/zeek: Fix build on armv7
Summary: [patch] security/zeek: Fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Craig Leres
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-05 18:37 UTC by Renato Botelho
Modified: 2020-11-06 18:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (leres)


Attachments
patch (541 bytes, patch)
2020-11-05 18:37 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer freebsd_triage 2020-11-05 18:37:58 UTC
Created attachment 219376 [details]
patch

When I tried to build it on armv7 it created a lib called Bro-freebsd-arm and pkg-plist contained Bro-freebsd-armv7.  Ports infrastructure doesn't offer a variable with `uname -m`, which is the one desired here instead of `uname -p` used to fill ARCH.

Add a variable with content of `uname -m` and use it to populate %%ARCH%% on PLIST
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-11-06 18:39:49 UTC
A commit references this bug:

Author: leres
Date: Fri Nov  6 18:38:47 UTC 2020
New revision: 554309
URL: https://svnweb.freebsd.org/changeset/ports/554309

Log:
  security/zeek: Fix build on armv7 and allow running as non-root user

  Apply Renato Botelho's fix for the ARCH used in PLIST_SUB (with
  some changes). Essentially use uname -m instead of trying to fix
  up the ARCH defined by bsd.port.mk (uname -p).

  While we're here:

   - Convert networks.cfg, node.cfg, and zeekctl.cfg to use @sample

   - Use @sample to avoid clobbering site.zeek (oops).

   - Remove unnecessary subshell for the post-build-NETMAP-on target.

   - Silence the annoying "use ZeekControl.plugin instead of
     BroControl.plugin" nag.

   - Reformat the rc.d script.

   - Update the rc.d script to honor the zeek_user rc.d variable and
     update pkg-message.in with hints on how to run as user zeek.

   - Explain how to configure zeek to ignore checksum errors when NIC
     checksum offloading is in use.

   - Make share/zeekctl/scripts owned by user zeek to allow "zeekctl
     install" when running as user zeek.

  PR:		250886
  Reported by:	garga

Changes:
  head/security/zeek/Makefile
  head/security/zeek/files/pkg-message.in
  head/security/zeek/files/zeek.in
  head/security/zeek/pkg-plist
Comment 2 Craig Leres freebsd_committer freebsd_triage 2020-11-06 18:40:59 UTC
Committed (with changes) along with some other changes I just happened to be working on.

Thanks for the patch!