Bug 251030 - lang/quickjs: fix build on GCC architectures
Summary: lang/quickjs: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-11 02:46 UTC by Piotr Kubaj
Modified: 2020-11-25 17:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch (2.91 KB, patch)
2020-11-11 02:46 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2020-11-11 02:46:57 UTC 
Created attachment 219537 [details]
patch

I'm sending a patch here because I'm not sure whether you like my approach.

Basically don't use Clang if we need to use GCC.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-11-25 17:49:40 UTC 
A commit references this bug:

Author: pkubaj
Date: Wed Nov 25 17:49:36 UTC 2020
New revision: 556299
URL: https://svnweb.freebsd.org/changeset/ports/556299

Log:
  lang/quickjs: fix build on GCC architectures

  Don't use Clang if we need to use GCC

  PR:		251030
  Approved by:	yuri (maintainer timeout)
  MFH:		2020Q4 (fix build blanket)

Changes:
  head/lang/quickjs/Makefile
  head/lang/quickjs/files/extra-clang-patch-Makefile
  head/lang/quickjs/files/extra-gcc-patch-Makefile
  head/lang/quickjs/files/patch-Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-11-25 17:50:41 UTC 
A commit references this bug:

Author: pkubaj
Date: Wed Nov 25 17:50:23 UTC 2020
New revision: 556300
URL: https://svnweb.freebsd.org/changeset/ports/556300

Log:
  MFH: r556299

  lang/quickjs: fix build on GCC architectures

  Don't use Clang if we need to use GCC

  PR:		251030
  Approved by:	yuri (maintainer timeout)

  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q4/
  branches/2020Q4/lang/quickjs/Makefile
  branches/2020Q4/lang/quickjs/files/extra-clang-patch-Makefile
  branches/2020Q4/lang/quickjs/files/extra-gcc-patch-Makefile
  branches/2020Q4/lang/quickjs/files/patch-Makefile