Bug 251128 - textproc/goldendict: fails to build with llvm10
Summary: textproc/goldendict: fails to build with llvm10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-14 09:25 UTC by Mikael Urankar
Modified: 2020-12-01 16:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bsam)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2020-11-14 09:25:46 UTC 
http://gohan03.nyi.freebsd.org/data/head-amd64-default-baseline/p554788_s367522/logs/errors/goldendict-1.5.0.g20190709_2.log

./sptr.hh:71:12: error: cannot initialize return object of type 'unsigned int' with an lvalue of type 'unsigned int *const'
  { return count; }
           ^~~~~

upstream fix: https://github.com/goldendict/goldendict/commit/f905b93de5386284166588ac1f05383af9aa1d2e
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-12-01 16:50:34 UTC 
A commit references this bug:

Author: mikael
Date: Tue Dec  1 16:50:01 UTC 2020
New revision: 556759
URL: https://svnweb.freebsd.org/changeset/ports/556759

Log:
  textproc/goldendict: Fix build with llvm10

  ./sptr.hh:71:12: error: cannot initialize return object of type 'unsigned int' with an lvalue of type 'unsigned int *const'
    { return count; }
             ^~~~~

  Import upstream fix

  PR:		251128
  Approved by:	bsam (maintainer timeout)

Changes:
  head/textproc/goldendict/Makefile
  head/textproc/goldendict/distinfo