Bug 251539 - devel/py-maturin: toml dependency is not just for building
Summary: devel/py-maturin: toml dependency is not just for building
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-02 18:21 UTC by andy
Modified: 2020-12-04 10:55 UTC (History)
0 users

See Also:
kai: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description andy 2020-12-02 18:21:11 UTC 
maturin shows textproc/py-toml as a build dependency, but it's also needed at runtime.
Comment 1 commit-hook freebsd_committer freebsd_triage 2020-12-04 10:42:08 UTC 
A commit references this bug:

Author: kai
Date: Fri Dec  4 10:41:36 UTC 2020
New revision: 556965
URL: https://svnweb.freebsd.org/changeset/ports/556965

Log:
  devel/py-maturin: Add missing RUN_DEPENDS

  * The RUN_DEPENDS are required when the maturin binary, which runs fine if
    issued directly, is used together with the Python code as a library.

  * Bump PORTREVISION due changed dependencies.

  PR:		251539
  Reported by:	andy@balholm.com

Changes:
  head/devel/py-maturin/Makefile
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2020-12-04 10:55:25 UTC 
(In reply to andy from comment #0)

Committed, thank you for reporting it!

I misread "setup.py" and then it slipped through the cracks as my test environment had textproc/py-toml still installed due to the BUILD_DEPENDS when I tested the import via Python.