Bug 251561 - math/libmesh: avoid unregistered conflict with math/metis
Summary: math/libmesh: avoid unregistered conflict with math/metis
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-03 12:46 UTC by Thierry Thomas
Modified: 2021-01-11 19:19 UTC (History)
1 user (show)

See Also:
yuri: maintainer-feedback+


Attachments
Use an external package for metis to avoid conflict (1.53 KB, patch)
2020-12-03 12:47 UTC, Thierry Thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2020-12-03 12:46:38 UTC
No conflict is registered, but both ports math/libmesh and math/metis install the file include/metis.h.

Using math/metis as an external dependency of math/libmesh removes that, as proposed in the attached patch.

Note: I have not detected any other conflict, but it would be smarter to avoid bundled packages and replace them by dependencies on external ports (e.g. tetgen, qhull, etc.)
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2020-12-03 12:47:37 UTC
Created attachment 220215 [details]
Use an external package for metis to avoid conflict
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-03 21:57:22 UTC
Approved.

Thank you for your patch!
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-12-04 10:48:12 UTC
A commit references this bug:

Author: thierry
Date: Fri Dec  4 10:47:53 UTC 2020
New revision: 556969
URL: https://svnweb.freebsd.org/changeset/ports/556969

Log:
  Avoid unregistered conflict with math/metis by using the external package
  and not the bundled one.

  PR:		251561
  Submitted by:	/me
  Approved by:	yuri (maintainer)

Changes:
  head/math/libmesh/Makefile
  head/math/libmesh/pkg-plist
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2021-01-11 19:19:36 UTC
Committed in 556969.