Created attachment 220326 [details] Patch devel/asl: Update to 1.42.183
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Now that we are here, WRKSRC should be after MAKE_ENV Thanks!
Added URL. The change log between the last version and this one is rather long.
Created attachment 220357 [details] Patch Updated patch that fixes WRKSRC order. Funny enough, portlint does not seem to complain about this particular order.
Hi there, The patched version does not build in poudriere: ===> Generating temporary packing list gmake[1]: Entering directory '/wrkdirs/usr/ports/devel/asl/work/asl-current' INSTROOT= OBJDIR= TARG_OBJDIR= TARG_EXEXTENSION= ./install.sh /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/bin /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/include/asl /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/man /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/lib/asl /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/share/doc/asl Installing files: mkdir: /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/include/asl/.: File exists chmod: /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/share/doc/asl/as_DE.*: No such file or directory chmod: /wrkdirs/usr/ports/devel/asl/work/stage/usr/local/share/doc/asl/as_EN.*: No such file or directory gmake[1]: Leaving directory '/wrkdirs/usr/ports/devel/asl/work/asl-current' ====> Compressing man pages (compress-man) =========================================================================== ====> Running Q/A tests (stage-qa) Error: 'bin/asl' is referring to /wrkdirs/usr/ports/devel/asl/work/stage Error: 'bin/p2bin' is referring to /wrkdirs/usr/ports/devel/asl/work/stage Error: 'bin/p2hex' is referring to /wrkdirs/usr/ports/devel/asl/work/stage Error: 'bin/alink' is referring to /wrkdirs/usr/ports/devel/asl/work/stage Error: 'bin/pbind' is referring to /wrkdirs/usr/ports/devel/asl/work/stage Error: 'bin/plist' is referring to /wrkdirs/usr/ports/devel/asl/work/stage *** Error code 1 Stop. make: stopped in /usr/ports/devel/asl =>> Error: stage-qa failures detected build of devel/asl | asl-1.42.183 ended at Wed Dec 9 10:32:50 CET 2020 build time: 00:00:14 !!! build failure encountered !!! Would you have a look at it?
Created attachment 220540 [details] Fix paths so it looks in the right place for localisation files.
I think the mkdir/chmod errors can be ignored because the docs aren't being built. I fixed the other issue by modifying Makefile.def to not use STAGEDIR, but instead pass it in as INSTROOT instead so the build uses the unstaged path but the install uses the staged one. I've attached a diff that applies on top of Kevin's and it installs, works and passes stage-qa.
(In reply to darius from comment #6) Thanks for taking a look and fixing!
(In reply to Kevin Zheng from comment #7) This does not seem to build in i386 (tested in 11.4 and 12.1): /sysdefs.h:1360:21: error: typedef redefinition with different types ('long' vs 'long long') Is files/patch-sysdefs.h correct?
(In reply to Fernando Apesteguía from comment #8) I don't have access to a modern i386 FreeBSD box :( Can you try the attached version of patch-sysdefs.h? I changed to used stdint/inttypes typedefs.
Created attachment 220597 [details] Version to use stdint/inttypes
Committed, Thanks!
A commit references this bug: Author: fernape Date: Wed Dec 16 14:23:33 UTC 2020 New revision: 558225 URL: https://svnweb.freebsd.org/changeset/ports/558225 Log: devel/asl: Update to 1.42.183 ChangeLog: http://john.ccac.rwth-aachen.de:8000/as/changelog PR: 251650 Submitted by: kevinz5000@gmail.com Reviewed by: doconnor@gsoft.com.au (maintainer) Changes: head/devel/asl/Makefile head/devel/asl/distinfo head/devel/asl/files/Makefile.def head/devel/asl/files/patch-Makefile head/devel/asl/files/patch-as.c head/devel/asl/files/patch-sysdefs.h head/devel/asl/pkg-plist