Bug 251717 - Update audio/soundtouch to 2.2
Summary: Update audio/soundtouch to 2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-10 01:38 UTC by Jose Alonso Cardenas Marquez
Modified: 2020-12-14 20:36 UTC (History)
1 user (show)

See Also:
crees: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2020-12-10 01:38:45 UTC 
- Update to 2.2. Some ports depend of audio/soundtouch and they have compiled without problems with this new version (it helps to fix a problem with audio/mixx too).

Patch file at: https://people.freebsd.org/~acm/ports/soundtouch.diff
Comment 1 Chris Rees freebsd_committer freebsd_triage 2020-12-10 11:28:41 UTC 
Thanks dude-- do you still have it checked out etc if I offered approval for you to commit?
Comment 2 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2020-12-12 01:45:40 UTC 
(In reply to Chris Rees from comment #1)

Yes I do. Give me your approval and I'll commit the changes
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2020-12-12 06:46:42 UTC 
This patch needs a little tweaking

PORTVERSION should be DISTVERSION
Ref: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-master_sites-gitlab-description

NEON optimization needs to be disabled on ARMv6 unless it's run-time detected

Supersedes PR 244512

Best regards,
Daniel
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-12-14 20:30:49 UTC 
A commit references this bug:

Author: acm
Date: Mon Dec 14 20:30:04 UTC 2020
New revision: 558105
URL: https://svnweb.freebsd.org/changeset/ports/558105

Log:
  - Update to 2.2

  PR:		251717
  Submitted by:	acm
  Approved by:	crees

Changes:
  head/audio/soundtouch/Makefile
  head/audio/soundtouch/distinfo
Comment 5 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2020-12-14 20:36:06 UTC 
(In reply to daniel.engberg.lists from comment #3)

- I changed PORTVERSION/DISTVERSION before of commit it. It seems like neon-optimizations are detected on run-time

Greetings