Bug 251718 - science/py-scipy: Update 1.2.2 -> 1.5.4
Summary: science/py-scipy: Update 1.2.2 -> 1.5.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-10 02:47 UTC by Yuri Victorovich
Modified: 2020-12-25 05:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (python)

Attachments
patch (1.97 KB, patch)
2020-12-10 02:47 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2020-12-10 02:47:37 UTC 
Created attachment 220417 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-23 23:37:54 UTC 
Committed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-12-23 23:39:29 UTC 
A commit references this bug:

Author: yuri
Date: Wed Dec 23 23:38:29 UTC 2020
New revision: 559036
URL: https://svnweb.freebsd.org/changeset/ports/559036

Log:
  science/py-scipy: Update 1.2.2 -> 1.5.4

  PR:		251718
  Approved by:	python (maintainer's timeout; 14 days)

Changes:
  head/science/py-scipy/Makefile
  head/science/py-scipy/distinfo
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2020-12-24 09:27:56 UTC 
Yuri, with this patch, this port depends both on libblas.so:math/blas and on 
libopenblas.so:math/openblas:

-BUILD_DEPENDS= ${PYNUMPY}
+BUILD_DEPENDS= ${PYNUMPY} \
+               ${PYTHON_PKGNAMEPREFIX}pip>0:devel/py-pip@${PY_FLAVOR} \
+               ${PYTHON_PKGNAMEPREFIX}pybind11>0:devel/py-pybind11@${PY_FLAVO
R}
+LIB_DEPENDS=   libblas.so:math/blas
 RUN_DEPENDS=   ${PYNUMPY}

-USES=          fortran python shebangfix
+USES=          blaslapack:openblas fortran python shebangfix

Do you really want that?

I guess that you should remove the line
LIB_DEPENDS=   libblas.so:math/blas
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2020-12-25 05:37:28 UTC 
(In reply to Thierry Thomas from comment #3)

Hi Thierry,

Both  LIB_DEPENDS=libblas.so:math/blas and USES=blaslapack:openblas were added in r559036, which is a redundancy, you are right.

However, it doesn't build without libblas.so:math/blas, but builds without blaslapack:openblas, so I am removing the latter instead.

Thanks for letting me know.

Yuri
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-12-25 05:42:22 UTC 
A commit references this bug:

Author: yuri
Date: Fri Dec 25 05:41:53 UTC 2020
New revision: 559210
URL: https://svnweb.freebsd.org/changeset/ports/559210

Log:
  science/py-scipy: Remove the recently added USES=blaslapack:openblas because LIB_DEPENDS=libblas.so:math/blas provides blas

  It does build with libblas.so:math/blas, but doesn't with blaslapack:openblas.

  PR:		251718
  Reported by:	thierry
  Approved by:	python (correction of the previous recent commit r559036)

Changes:
  head/science/py-scipy/Makefile