Created attachment 220472 [details] Patch (Revision 1) Passes poudriere.
New version 2.30.4. Patch on Phabricator: https://reviews.freebsd.org/D28288
A commit references this bug: Author: nc Date: Sat Jan 23 15:41:10 UTC 2021 New revision: 562401 URL: https://svnweb.freebsd.org/changeset/ports/562401 Log: www/webkit2-gtk3: Update to 2.30.4 PR: 251771 Reviewed by: 0mp (mentor), tcberner Approved by: 0mp (mentor), tcberner Differential Revision: https://reviews.freebsd.org/D28288 Changes: head/www/webkit2-gtk3/Makefile head/www/webkit2-gtk3/distinfo head/www/webkit2-gtk3/files/patch-icu68 head/www/webkit2-gtk3/pkg-plist
It seems to be broken on aarch64: http://ampere2.nyi.freebsd.org/data/main-arm64-default/p563982_scb7cc72c54/logs/errors/webkit2-gtk3-2.30.4.log /usr/bin/c++ -DBUILDING_GTK__=1 -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DJSC_COMPILATION -DJSC_GLIB_API_ENABLED -DJavaScriptCore_EXPORTS -DSTATICALLY_LINKED_WITH_WTF -DSVN_REVISION=\"tarball\" -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -IDerivedSources/ForwardingHeaders -I. -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/API -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/assembler -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/b3 -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/b3/air -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/bindings -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/builtins -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/bytecode -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/bytecompiler -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/dfg -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/disassembler -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/disassembler/ARM64 -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/disassembler/udis86 -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/domjit -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/ftl -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/heap -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/debugger -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/inspector -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/inspector/agents -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/inspector/augmentable -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/inspector/remote -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/interpreter -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/llint -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/parser -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/profiler -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/runtime -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/tools -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/wasm -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/wasm/js -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/yarr -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr -IDerivedSources/ForwardingHeaders/JavaScriptCore/glib -IDerivedSources/JavaScriptCore/javascriptcoregtk/jsc -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/API/glib -IDerivedSources/JavaScriptCore/javascriptcoregtk -I/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/inspector/remote/glib -isystem /usr/local/include/glib-2.0 -isystem /usr/local/lib/glib-2.0/include -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Wno-noexcept-type -Wno-psabi -Wno-parentheses-equality -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -O2 -pipe -DNDEBUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=32 -B/usr/bin -isystem /usr/local/include -fno-strict-aliasing -fno-exceptions -fno-rtti -O2 -pipe -DNDEBUG -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=32 -B/usr/bin -isystem /usr/local/include -fPIC -ffp-contract=off -fno-slp-vectorize -pthread -std=c++17 -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp.o -c DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp:2: /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:805:33: error: use of undeclared identifier 'numberOfRegions'; did you mean 'NumberOfOptions'? std::array<RegionAllocator, numberOfRegions> m_allocators; ^~~~~~~~~~~~~~~ NumberOfOptions /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/runtime/OptionsList.h:582:18: note: 'NumberOfOptions' declared here constexpr size_t NumberOfOptions = countNumberOfJSCOptions(); ^ In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp:2: /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:370:78: error: use of undeclared identifier 'numberOfRegions'; did you mean 'NumberOfOptions'? : m_allocators(constructFixedSizeArrayWithArguments<RegionAllocator, numberOfRegions>(*this)) ^~~~~~~~~~~~~~~ NumberOfOptions /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/runtime/OptionsList.h:582:18: note: 'NumberOfOptions' declared here constexpr size_t NumberOfOptions = countNumberOfJSCOptions(); ^ In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp:2: /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:381:36: error: use of undeclared identifier 'numberOfRegions'; did you mean 'NumberOfOptions'? for (size_t i = 0; i < numberOfRegions; ++i) { ^~~~~~~~~~~~~~~ NumberOfOptions /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/runtime/OptionsList.h:582:18: note: 'NumberOfOptions' declared here constexpr size_t NumberOfOptions = countNumberOfJSCOptions(); ^ In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp:2: /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:384:104: error: use of undeclared identifier 'regionSize' m_allocators[i].m_end = tagCodePtr<ExecutableMemoryPtrTag>(bitwise_cast<void*>(start + regionSize)); ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:387:41: error: use of undeclared identifier 'numberOfRegions'; did you mean 'NumberOfOptions'? RELEASE_ASSERT(i == numberOfRegions - 1); ^~~~~~~~~~~~~~~ NumberOfOptions DerivedSources/ForwardingHeaders/wtf/Assertions.h:582:20: note: expanded from macro 'RELEASE_ASSERT' if (UNLIKELY(!(assertion))) \ ^ DerivedSources/ForwardingHeaders/wtf/Compiler.h:354:41: note: expanded from macro 'UNLIKELY' #define UNLIKELY(x) __builtin_expect(!!(x), 0) ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/runtime/OptionsList.h:582:18: note: 'NumberOfOptions' declared here constexpr size_t NumberOfOptions = countNumberOfJSCOptions(); ^ In file included from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-3a3c4ec0-2.cpp:2: /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:393:66: error: use of undeclared identifier 'regionSize' RELEASE_ASSERT(m_allocators[i].allocatorSize() < regionSize); ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:397:26: error: use of undeclared identifier 'regionSize' start += regionSize; ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:586:88: error: use of undeclared identifier 'regionSize' RegionAllocator* allocator = findRegion(jumpLocation > target ? jumpLocation - regionSize : jumpLocation); ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:599:92: error: use of undeclared identifier 'islandSizeInBytes' LinkBuffer linkBuffer(jit, MacroAssemblerCodePtr<NoPtrTag>(currentIsland), islandSizeInBytes, JITCompilationMustSucceed, false); ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:621:51: error: use of undeclared identifier 'regionSize' nextIslandRegion = jumpLocation - regionSize; ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:623:51: error: use of undeclared identifier 'regionSize' nextIslandRegion = jumpLocation + regionSize; ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:685:28: error: use of undeclared identifier 'islandRegionSize' return end() - islandRegionSize; ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:695:50: error: use of undeclared identifier 'islandSizeInBytes' size_t islandsPerPage = pageSize() / islandSizeInBytes; ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:715:61: error: use of undeclared identifier 'islandSizeInBytes' uintptr_t result = end - ((resultBit + 1) * islandSizeInBytes); ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:723:46: error: use of undeclared identifier 'maxIslandsPerRegion' if (UNLIKELY(islandBits.size() > maxIslandsPerRegion)) ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:726:62: error: use of undeclared identifier 'islandSizeInBytes' uintptr_t pageBegin = end - (islandBits.size() * islandSizeInBytes); // [islandBegin, end) ^ /wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.30.4/Source/JavaScriptCore/jit/ExecutableAllocator.cpp:743:42: error: use of undeclared identifier 'islandSizeInBytes'