Created attachment 220479 [details]
QA log for devel/tailor

This is the QA log for devel/tailor.

Comment 2 Rainer Hurling 2020-12-12 19:58:12 UTC

Hi Chris,

I just added a review of your patch in Phabricator [1], with some modifications.

Could you please try, if it works for you?

I hope you agree with the changes ;)

[1] https://reviews.freebsd.org/D27590

Created attachment 220513 [details]
svn diff for devel/tailor: obsoletes previous diff

This diff updates previous diff with proposed changes
kindly submitted by Rainer -- thanks! :-)

--Chris

(In reply to Rainer Hurling from comment #2)
Thank you very much for your proposal Rainer!
I tried the differential route. But failed. :-(

Comment 5 Rainer Hurling 2020-12-13 06:27:13 UTC

(In reply to Chris Hutchinson from comment #4)

Your newest diff also produces a Python executable, which does not run for me:

---------------------
#tailor
  File "/usr/local/bin/tailor", line 36
    except TailorException, exc:
                          ^
SyntaxError: invalid syntax
---------------------

Could you please investigate into it, thanks :)



And I would suggest that you close review D27593 on Phabricator [1], opened by mistake. This can be done under 'Add action' at the near bottom of the page.

[1] https://reviews.freebsd.org/D27593

Created attachment 220572 [details]
svn diff version 4 for devel/tailor

OK this patch has been *fully* tested, and works as
intended -- both as a build target. As well as a working
application.

Changes:
MOVED (reintroduce port)
UPDATE to 0.9.36
ADDS devel/py-future as shim (2.x && 3.7+ support)
ADDS autoplist
REMOVES pkg-plist
NOTE:
This works fine on 3.7.9. But should also work on 2.7
(untested on 2.7)

That's it.

A BIG thanks go out to Rainer Hurling for all his time
on this.

Thanks!

--Chris

(In reply to Rainer Hurling from comment #5)
> And I would suggest that you close review D27593 on Phabricator [1], opened by
> mistake. This can be done under 'Add action' at the near bottom of the page.

Done! :-)

Comment 8 Rainer Hurling 2020-12-15 07:26:59 UTC

(In reply to Chris Hutchinson from comment #6)

Hi Chris,

Thanks for the updated patch. It fetches, builds and installs fine.

One last problem seems to exist: I think you accidentally listed rsync under BUILD_DEPENDS instead of RUN_DEPENDS. As far as I understand 'tailor', it uses rsync at runtime?

If that is correct, I will swap ${LOCALBASE}/bin/rsync:net/rsync to RUN_DEPENDS accordingly. I don't need another patch from you for that ;)

(In reply to Rainer Hurling from comment #8)
Sigh... sorry about that.
You are, of course, correct. I'm afraid I have
too much to do, with too little time. :-P

Thanks, Rainer!

--Chris

Comment 10 commit-hook 2020-12-15 10:25:54 UTC

A commit references this bug:

Author: rhurlin
Date: Tue Dec 15 10:24:59 UTC 2020
New revision: 558151
URL: https://svnweb.freebsd.org/changeset/ports/558151

Log:
  devel/tailor: Re-add port and update to 0.9.36

  Re-add expired port and update from 0.9.35 to 0.9.36.
  Use Python 3.7+ now.

  PR:		251777
  Submitted by:	Chris Hutchinson <portmaster@bsdforge.com> (maintainer)
  Approved by:	arrowd (mentor)
  Differential Revision:	https://reviews.freebsd.org/D27590

Changes:
  head/MOVED
  head/devel/Makefile
  head/devel/tailor/
  head/devel/tailor/Makefile
  head/devel/tailor/distinfo
  head/devel/tailor/pkg-plist

Comment 11 Rainer Hurling 2020-12-15 10:28:19 UTC

Committed, thanks :)

(In reply to Rainer Hurling from comment #11)
No. Thank *you*. :-)