Created attachment 220694 [details] libretro-vice-v1.diff Vice is a Commodore computer emulator. They use the exact same source but it needs to recompile in order to generate a specific libretro core, so I've made individual ports and submitted as a single patch. This is the list of cores: libretro-vice_x128: a C128 emulator libretro-vice_x64: a C64 emulator libretro-vice_x64sc: a C64 emulator focused on accuracy libretro-vice_xcbm2: a CBM-6x0/7x0 emulator libretro-vice_xcbm5x0: a CBM-5x0 emulator libretro-vice_xpet: a PET emulator libretro-vice_xplus4: a PLUS4 emulator libretro-vice_xscpu64: a C64 emulator with a SuperCPU cart libretro-vice_xvic: a VIC20 emulator
Created attachment 220849 [details] port with flavors Hi Daniel. Since all these ports are basically the same, I suggest converting them to a single port with FLAVORS. What do you think? btw, I don't see why these ports need all that stuff in USES (except gmake) and USE_SDL. Am I missing something?
I also think emulators category is more appropriate for this port.
(In reply to Max Brazhnikov from comment #1) With flavors will make difficult to adequate for libretro-meta (I mean, to have all the cores installed at once, afaik). About the category, they made me change from emulators to games some time ago and I did changed all the cores from emulators to games.
(In reply to Daniel Menelkir from comment #3) > With flavors will make difficult to adequate for libretro-meta (I mean, to have > all the cores installed at once, afaik). Absolutely no difference to usual ports. > About the category, they made me change from emulators to games some time ago > and I did changed all the cores from emulators to games. Oh, I see now. I won't insist on moving the ports to emulators, but I still think it's more suitable.
(In reply to Max Brazhnikov from comment #4) I totally agree with being in emulators. Let's use the flavors version then.
A commit references this bug: Author: makc Date: Sat Jan 2 20:40:37 UTC 2021 New revision: 559963 URL: https://svnweb.freebsd.org/changeset/ports/559963 Log: Add new port emulators/libretro-vice: libretro cores for emulating Commodore computers. PR: 251936 Submitted by: Daniel Menelkir Changes: head/emulators/Makefile head/emulators/libretro-vice/ head/emulators/libretro-vice/Makefile head/emulators/libretro-vice/distinfo head/emulators/libretro-vice/files/ head/emulators/libretro-vice/files/patch-vice_src_rtc_rtc.h head/emulators/libretro-vice/pkg-descr
Done, thanks!