Bug 252286 - devel/notcurses: upgrade to 2.1.3
Summary: devel/notcurses: upgrade to 2.1.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/dankamongmen/notcu...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-30 14:18 UTC by nick black
Modified: 2020-12-31 19:11 UTC (History)
2 users (show)

See Also:

Attachments
git diff 2.1.0 -> 2.1.2 (1.33 KB, patch)
2020-12-30 14:18 UTC, nick black 		nickblack: maintainer-approval+
Details | Diff
git diff 2.1.0 -> 2.1.2 with nccell->cell man page change, new progbar man page (2.36 KB, patch)
2020-12-31 05:56 UTC, nick black 		nickblack: maintainer-approval+
Details | Diff
2.1.0 -> 2.1.3 git diff (2.36 KB, patch)
2020-12-31 08:52 UTC, nick black 		nickblack: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description nick black 2020-12-30 14:18:48 UTC 
Created attachment 221105 [details]
git diff 2.1.0 -> 2.1.2
Comment 1 Joseph Mingrone freebsd_committer freebsd_triage 2020-12-30 21:20:13 UTC 
`poudriere testport` reports a plist error.

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: share/man/man3/notcurses_cell.3.gz
Error: Orphaned: share/man/man3/notcurses_progbar.3.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: share/man/man3/notcurses_nccell.3.gz
===> Error: Plist issues found.

Full build log here: http://pkg.awarnach.mathstat.dal.ca/data/12amd64-default/2020-12-30_12h10m44s/logs/errors/notcurses-2.1.2.log

You probably don't need to submit a new patch since it's a simple fix for the committer, but I won't speak definitively for fernape@.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-30 21:37:00 UTC 
(In reply to Joseph Mingrone from comment #1)

Hi Joseph, thanks for the build test. My machine is still building lang/ghc which is taking a while :S

But sure, there is no need for a corrected patch. I will take care of that... probably tomorrow.

Thanks!
Comment 3 nick black 2020-12-31 05:55:32 UTC 
I've got a corrected patch. Sorry about that! Replacing it now.
Comment 4 nick black 2020-12-31 05:56:37 UTC 
Created attachment 221118 [details]
git diff 2.1.0 -> 2.1.2 with nccell->cell man page change, new progbar man page
Comment 5 nick black 2020-12-31 08:48:42 UTC 
I just released 2.1.3 upstream so I'm going to go ahead and refresh this patch; please do not merge the 2.1.2 diff.
Comment 6 nick black 2020-12-31 08:52:57 UTC 
Created attachment 221120 [details]
2.1.0 -> 2.1.3 git diff

Upgrades all the way to 2.1.3, just released today (2020-12-31).
Incorporates feedback provided earlier.
Obsoletes all previous patches.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-31 10:13:43 UTC 
build testing...
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-12-31 19:10:47 UTC 
A commit references this bug:

Author: fernape
Date: Thu Dec 31 19:10:04 UTC 2020
New revision: 559766
URL: https://svnweb.freebsd.org/changeset/ports/559766

Log:
  devel/notcurses: upgrade to 2.1.3

  ChangeLogs:
  	https://github.com/dankamongmen/notcurses/releases/tag/v2.1.2
  	https://github.com/dankamongmen/notcurses/releases/tag/v2.1.3

  PR:	252286
  Submitted by:	nickblack@linux.com (maintainer)

Changes:
  head/devel/notcurses/Makefile
  head/devel/notcurses/distinfo
  head/devel/notcurses/pkg-plist
Comment 9 Fernando Apesteguía freebsd_committer freebsd_triage 2020-12-31 19:11:13 UTC 
Committed,

Thanks!