Created attachment 221242 [details] diff for new port textproc/md4c Markdown Parser in C. Needed for Purism L5 Simple Diary app. https://lists.freebsd.org/pipermail/freebsd-ports/2021-January/119979.html Contains md4c and md2html. This is my first svn diff and maintaining for a port, hopefully it contains all things needed.
I applied the patch which gives some messages: root@c720-r368166:/usr/ports # patch -p0 < ~guru/md4c.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: textproc/md4c/Makefile |=================================================================== |--- textproc/md4c/Makefile (nicht existent) |+++ textproc/md4c/Makefile (Arbeitskopie) -------------------------- (Creating file textproc/md4c/Makefile...) Patching file textproc/md4c/Makefile using Plan A... Empty context always matches. Hunk #1 succeeded at 1. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- | |Property changes on: textproc/md4c/Makefile |___________________________________________________________________ |Added: svn:eol-style |## -0,0 +1 ## |+native |\ No newline at end of property |Added: svn:keywords |## -0,0 +1 ## |+FreeBSD=%H |\ No newline at end of property |Added: svn:mime-type |## -0,0 +1 ## |+text/plain |\ No newline at end of property |Index: textproc/md4c/distinfo |=================================================================== |--- textproc/md4c/distinfo (nicht existent) |+++ textproc/md4c/distinfo (Arbeitskopie) -------------------------- (Creating file textproc/md4c/distinfo...) Patching file textproc/md4c/distinfo using Plan A... Empty context always matches. Hunk #1 succeeded at 1. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- | |Property changes on: textproc/md4c/distinfo |___________________________________________________________________ |Added: fbsd:nokeywords |## -0,0 +1 ## |+yes |\ No newline at end of property |Added: svn:eol-style |## -0,0 +1 ## |+native |\ No newline at end of property |Added: svn:mime-type |## -0,0 +1 ## |+text/plain |\ No newline at end of property |Index: textproc/md4c/pkg-descr |=================================================================== |--- textproc/md4c/pkg-descr (nicht existent) |+++ textproc/md4c/pkg-descr (Arbeitskopie) -------------------------- (Creating file textproc/md4c/pkg-descr...) Patching file textproc/md4c/pkg-descr using Plan A... Empty context always matches. Hunk #1 succeeded at 1. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- | |Property changes on: textproc/md4c/pkg-descr |___________________________________________________________________ |Added: fbsd:nokeywords |## -0,0 +1 ## |+yes |\ No newline at end of property |Added: svn:eol-style |## -0,0 +1 ## |+native |\ No newline at end of property |Added: svn:mime-type |## -0,0 +1 ## |+text/plain |\ No newline at end of property |Index: textproc/md4c/pkg-plist |=================================================================== |--- textproc/md4c/pkg-plist (nicht existent) |+++ textproc/md4c/pkg-plist (Arbeitskopie) -------------------------- (Creating file textproc/md4c/pkg-plist...) Patching file textproc/md4c/pkg-plist using Plan A... Empty context always matches. Hunk #1 succeeded at 1. Hmm... Ignoring the trailing garbage. done but 'make' and 'make install' do fine: root@c720-r368166:/usr/ports/textproc/md4c # make install ===> Installing for md4c-0.4.7 ===> Checking if md4c is already installed ===> Registering installation for md4c-0.4.7 Installing md4c-0.4.7...
Thank you for trying this. Does this mean something in the diff is missing or needs to be edited? Greetings, Henrik Rosenke
I think for each file in the diff the part about the SVN properties shouldn't be there. How do you created the file?
(In reply to Matthias Apitz from comment #3) maybe this was caused by creating this on my ubuntu workstation, i have built the port on our poudriere Server but the Server has an older portstree. So i checked it out on my workstation, and created the svn diff there. i can filter this via svn diff | filterdiff --clean but this surpresses this section: Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property But it seems other ports got this property line in their diff as well? See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252460 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252412 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243845
L15 should say DISTVERSION instead of PORTVERSION for consistency. L3 in pkg-descr should be separated from the rest of the text and the text should be a bit more verbose. Looks good to me otherwise! Best regards, Daniel
Created attachment 221478 [details] new-diff-md4c Thanks for the tips Daniel, i added these Changes to the new diff.
Poudriere testport OK 12.2-RELEASE (amd64) Poudriere testport OK 11.4-RELEASE (amd64)
A commit references this bug: Author: arrowd Date: Wed Feb 17 10:36:56 UTC 2021 New revision: 565494 URL: https://svnweb.freebsd.org/changeset/ports/565494 Log: textproc/md4c: Create the port. md4c is a markdown parser written in C. PR: 252383 Submitted by: Henrik Rosenke <rosenke@dssgmbh.de> Reviewed by: Matthias Apitz <guru@unixarea.de>, daniel.engberg.lists@pyret.net Changes: head/textproc/Makefile head/textproc/md4c/ head/textproc/md4c/Makefile head/textproc/md4c/distinfo head/textproc/md4c/pkg-descr head/textproc/md4c/pkg-plist
Committed, thanks everyone involved.